[vlc-commits] smb: fix use after free (cid #1348119)

[Tristan Matthews]

vlc | branch: master | Tristan Matthews <tmatth at videolan.org> | Wed Jan 13 08:42:07 2016 -0500| [6a50afb60d8ded56645462af89cd0b51b00a8df8] | committer: Tristan Matthews

smb: fix use after free (cid #1348119)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6a50afb60d8ded56645462af89cd0b51b00a8df8
---

 modules/access/smb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/access/smb.c b/modules/access/smb.c
index 8d3ffb0..d3e2c21 100644
--- a/modules/access/smb.c
+++ b/modules/access/smb.c
@@ -252,8 +252,8 @@ static int Open( vlc_object_t *p_this )
     {
         msg_Err( p_access, "open failed for '%s' (%s)",
                  p_access->psz_location, vlc_strerror_c(errno) );
-        free( p_sys );
         vlc_UrlClean( &p_sys->url );
+        free( p_sys );
         return VLC_EGENERIC;
     }