[vlc-commits] qt: fix invalid free if aout_DevicesList() fails

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Jul 27 19:49:01 2016 +0300| [f21febe7c0cfcaa9ac753e44fdc849fd7a9ee50a] | committer: Rémi Denis-Courmont

qt: fix invalid free if aout_DevicesList() fails

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f21febe7c0cfcaa9ac753e44fdc849fd7a9ee50a
---

 modules/gui/qt/menus.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/modules/gui/qt/menus.cpp b/modules/gui/qt/menus.cpp
index 799aa5a..8af0317 100644
--- a/modules/gui/qt/menus.cpp
+++ b/modules/gui/qt/menus.cpp
@@ -1547,6 +1547,9 @@ void VLCMenuBar::updateAudioDevice( intf_thread_t * p_intf, audio_output_t *p_ao
 
     current->clear();
     int i_result = aout_DevicesList( p_aout, &ids, &names);
+    if( i_result < 0 )
+        return;
+
     selected = aout_DeviceGet( p_aout );
 
     QActionGroup *actionGroup = new QActionGroup(current);