[vlc-commits] decoder: don't set dec->b_error if aout_update_format fails

Thomas Guillem git at videolan.org
Thu Jul 28 09:04:35 CEST 2016


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Wed Jul  6 18:44:27 2016 +0200| [6ab7c8db1676d50bf9308abcb7f3138af0c41a15] | committer: Thomas Guillem

decoder: don't set dec->b_error if aout_update_format fails

The module calling this function should handle the error, not the core. A
module may call this function again in case of a fail, but with a different
fmt_out. That is the case of avcodec video (audio decoders should be able to do
the same).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6ab7c8db1676d50bf9308abcb7f3138af0c41a15
---

 src/input/decoder.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/input/decoder.c b/src/input/decoder.c
index 06e569d..43a05da 100644
--- a/src/input/decoder.c
+++ b/src/input/decoder.c
@@ -302,7 +302,6 @@ static int aout_update_format( decoder_t *p_dec )
         if( p_aout == NULL )
         {
             msg_Err( p_dec, "failed to create audio output" );
-            p_dec->b_error = true;
             return -1;
         }
 



More information about the vlc-commits mailing list