[vlc-commits] dialog: don't clear array when changing callbacks

Thomas Guillem git at videolan.org
Sat Jun 4 13:18:31 CEST 2016


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Sat Jun  4 13:15:57 2016 +0200| [5e6042333989fd25ecd9b0640d68e94c369264e2] | committer: Thomas Guillem

dialog: don't clear array when changing callbacks

This array will be clear by dialog owners.
This fix a crash when a dialog owner release dialogs that were invalidated.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5e6042333989fd25ecd9b0640d68e94c369264e2
---

 src/interface/dialog.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/src/interface/dialog.c b/src/interface/dialog.c
index c21939c..d0752b1 100644
--- a/src/interface/dialog.c
+++ b/src/interface/dialog.c
@@ -237,7 +237,6 @@ dialog_clear_all_locked(vlc_dialog_provider *p_provider)
             vlc_array_item_at_index(&p_provider->dialog_array, i);
         dialog_cancel_locked(p_provider, p_id);
     }
-    vlc_array_clear(&p_provider->dialog_array);
 }
 
 void



More information about the vlc-commits mailing list