[vlc-commits] subtitles: update MicroDVD comment

Jean-Baptiste Kempf git at videolan.org
Mon Jun 27 15:37:36 CEST 2016


vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Mon Jun 27 15:29:47 2016 +0200| [41d6e6695f008bba96e616a38ba7cded37f492e4] | committer: Jean-Baptiste Kempf

subtitles: update MicroDVD comment

Ref #1825

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=41d6e6695f008bba96e616a38ba7cded37f492e4
---

 modules/codec/subsdec.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/modules/codec/subsdec.c b/modules/codec/subsdec.c
index 681750d..e8f9b87 100644
--- a/modules/codec/subsdec.c
+++ b/modules/codec/subsdec.c
@@ -934,14 +934,19 @@ static text_segment_t* ParseSubtitles( int *pi_align, const char *psz_subtitle )
             psz_subtitle = strchr( psz_subtitle, '}' ) + 1;
         }
         /* MicroDVD extensions */
+        /* FIXME:
+         *  - Currently, we don't do difference between X and x, and we should:
+         *    Capital Letters applies to the whole text and not one line
+         *  - We don't support Position and Coordinates
+         *  - We don't support the DEFAULT flag (HEADER)
+         */
+
         else if( psz_subtitle[0] == '{' &&
                  psz_subtitle[2] == ':' && strchr( &psz_subtitle[2], '}' ) )
         {
             const char *psz_tag_end = strchr( &psz_subtitle[2], '}' );
             size_t i_len = psz_tag_end - &psz_subtitle[3];
 
-            // FIXME: We don't do difference between X and x, and we should:
-            // Capital Letters applies to the whole text and not one line
             if( psz_subtitle[1] == 'Y' || psz_subtitle[1] == 'y' )
             {
                 if( psz_subtitle[3] == 'i' )



More information about the vlc-commits mailing list