[vlc-commits] mkv: removed manual memory management from Tags + SimpleTags

[Filip Roséen]

vlc | branch: master | Filip Roséen <filip at atch.se> | Fri Mar  4 17:04:14 2016 +0100| [2eca52d3e3eea2f82d20134466286f498b10aba3] | committer: Jean-Baptiste Kempf

mkv: removed manual memory management from Tags + SimpleTags

In order to provide better runtime safety manual management of dynamic
memory has been removed from `class Tags` and `class SimpleTags`.

This includes introducing usage of `std::vector` as well as
`std::string`, while also removing data-members that are no longer
required.

 - SimpleTag::b_default has been removed since it was written to (at
   once place), but never read; the write has been replaced by a comment.

 - The ParseSimpleTag function has been changed to return `bool` instead
   of a pointer to signal whether parsing was successful. The result
   will be written to `pout_simple` (instead of being indirectly
   returned through a pointer).

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2eca52d3e3eea2f82d20134466286f498b10aba3
---

 modules/demux/mkv/demux.cpp            |   14 ++--
 modules/demux/mkv/matroska_segment.cpp |  117 ++++++++++++--------------------
 modules/demux/mkv/matroska_segment.hpp |   24 +++----
 3 files changed, 62 insertions(+), 93 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=2eca52d3e3eea2f82d20134466286f498b10aba3