[vlc-commits] mkv: cleanup of matroska_segment_c::ParseTrackEntry

Filip Roséen git at videolan.org
Mon May 9 15:09:27 CEST 2016


vlc | branch: master | Filip Roséen <filip at videolabs.io> | Mon May  9 14:53:08 2016 +0200| [d9d906e0b85db7e031820346e16f46efb4749ff0] | committer: Jean-Baptiste Kempf

mkv: cleanup of matroska_segment_c::ParseTrackEntry

A few more lines, but far easier to read; and we should definitely
prefer maintainability instead of striving for just as few LOCs as
possible.

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d9d906e0b85db7e031820346e16f46efb4749ff0
---

 modules/demux/mkv/matroska_segment_parse.cpp |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/modules/demux/mkv/matroska_segment_parse.cpp b/modules/demux/mkv/matroska_segment_parse.cpp
index c8c6b60..ae84a71 100644
--- a/modules/demux/mkv/matroska_segment_parse.cpp
+++ b/modules/demux/mkv/matroska_segment_parse.cpp
@@ -596,7 +596,10 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
         }
         E_CASE( KaxAudioSamplingFreq, afreq )
         {
-            vars.tk->i_original_rate = vars.tk->fmt.audio.i_rate = static_cast<float>( afreq );
+            float const value = static_cast<float>( afreq );
+
+            vars.tk->i_original_rate  = value;
+            vars.tk->fmt.audio.i_rate = value;
             debug( vars, "afreq=%d", vars.tk->fmt.audio.i_rate ) ;
         }
         E_CASE( KaxAudioOutputSamplingFreq, afreq )



More information about the vlc-commits mailing list