[vlc-commits] playlist: playlist_RecursiveNodeSort() asserts the playlist lock

Rémi Denis-Courmont git at videolan.org
Wed Nov 16 23:05:06 CET 2016


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Nov 16 23:12:27 2016 +0200| [ffaa3171985fb2a57d5eeb67d89e93c2c5a5f7fe] | committer: Rémi Denis-Courmont

playlist: playlist_RecursiveNodeSort() asserts the playlist lock

As any function that requires a valid playlist item as parameter, the
function can only make sense with the lock already held by the caller.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ffaa3171985fb2a57d5eeb67d89e93c2c5a5f7fe
---

 src/playlist/sort.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/playlist/sort.c b/src/playlist/sort.c
index 1b6d1b6..588bd35 100644
--- a/src/playlist/sort.c
+++ b/src/playlist/sort.c
@@ -193,6 +193,8 @@ static int recursiveNodeSort( playlist_t *p_playlist, playlist_item_t *p_node,
 int playlist_RecursiveNodeSort( playlist_t *p_playlist, playlist_item_t *p_node,
                                 int i_mode, int i_type )
 {
+    PL_ASSERT_LOCKED;
+
     /* Ask the playlist to reset as we are changing the order */
     pl_priv(p_playlist)->b_reset_currently_playing = true;
 



More information about the vlc-commits mailing list