[vlc-commits] Revert "Qt4: make video widget not eat mouse click events"

Rémi Denis-Courmont git at videolan.org
Tue Nov 29 18:57:42 CET 2016


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov 29 19:54:23 2016 +0200| [e496e5c3fc6b33675fe43847770ad88de67c15cc] | committer: Rémi Denis-Courmont

Revert "Qt4: make video widget not eat mouse click events"

This reverts commit bd057d1bbcde511df0a1fc2c3128ab252ff20095.
This very old hack is no longer necessary.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e496e5c3fc6b33675fe43847770ad88de67c15cc
---

 modules/gui/qt/components/interface_widgets.cpp | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/modules/gui/qt/components/interface_widgets.cpp b/modules/gui/qt/components/interface_widgets.cpp
index 89e2b78..256d99d 100644
--- a/modules/gui/qt/components/interface_widgets.cpp
+++ b/modules/gui/qt/components/interface_widgets.cpp
@@ -140,18 +140,6 @@ WId VideoWidget::request( struct vout_window_t *p_wnd, unsigned int *pi_width,
 
     layout->addWidget( stable );
 
-#ifdef Q_WS_X11
-    /* HACK: Only one X11 client can subscribe to mouse button press events.
-     * VLC currently handles those in the video display.
-     * Force Qt to unsubscribe from mouse press and release events. */
-    Display *dpy = QX11Info::display();
-    Window w = stable->winId();
-    XWindowAttributes attr;
-
-    XGetWindowAttributes( dpy, w, &attr );
-    attr.your_event_mask &= ~(ButtonPressMask|ButtonReleaseMask);
-    XSelectInput( dpy, w, attr.your_event_mask );
-#endif
     sync();
     p_window = p_wnd;
     return stable->winId();



More information about the vlc-commits mailing list