[vlc-commits] Qt: remove V4L2 spin box control

Rémi Denis-Courmont git at videolan.org
Sat Oct 22 11:14:46 CEST 2016


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Oct 22 11:42:28 2016 +0300| [229a415f55d83eb2807485b4a70d74b57a3561b4] | committer: Rémi Denis-Courmont

Qt: remove V4L2 spin box control

The only V4L2 controls "without" minima and maxima are the 64-bits
integers. Those are not handled properly by the Qt UI anyway, since
neither the QSpinBox nor the Q(Abstract)Slider support the proper
range of values.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=229a415f55d83eb2807485b4a70d74b57a3561b4
---

 modules/gui/qt/components/extended_panels.cpp | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/modules/gui/qt/components/extended_panels.cpp b/modules/gui/qt/components/extended_panels.cpp
index 2351fce..c44bed5 100644
--- a/modules/gui/qt/components/extended_panels.cpp
+++ b/modules/gui/qt/components/extended_panels.cpp
@@ -804,7 +804,6 @@ void ExtV4l2::Refresh( void )
                         hlayout->addWidget( combobox );
                     }
                     else
-                    if( (i_type & VLC_VAR_HASMIN) && (i_type & VLC_VAR_HASMAX) )
                     {
                         QSlider *slider = new QSlider( box );
                         slider->setObjectName( qfu( psz_var ) );
@@ -828,17 +827,6 @@ void ExtV4l2::Refresh( void )
                                  ValueChange( int ) );
                         hlayout->addWidget( slider );
                     }
-                    else
-                    {
-                        QSpinBox *spinBox = new QSpinBox( box );
-                        spinBox->setObjectName( qfu( psz_var ) );
-                        spinBox->setMinimum( INT_MIN );
-                        spinBox->setMaximum( INT_MAX );
-                        spinBox->setValue( i_val );
-                        CONNECT( spinBox, valueChanged( int ), this,
-                                 ValueChange( int ) );
-                        hlayout->addWidget( spinBox );
-                    }
                     layout->addLayout( hlayout );
                     break;
                 }



More information about the vlc-commits mailing list