[vlc-commits] lib: leave the "crop" variable choices as they are

Rémi Denis-Courmont git at videolan.org
Sat Oct 22 16:56:22 CEST 2016


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Oct 22 17:54:07 2016 +0300| [05105392b399866f0c7a2f2b2122713a8f708d05] | committer: Rémi Denis-Courmont

lib: leave the "crop" variable choices as they are

There is no longer a need to override it, since unlisted values are now
permitted for variables.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=05105392b399866f0c7a2f2b2122713a8f708d05
---

 lib/video.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/lib/video.c b/lib/video.c
index 8655a32..1046fba 100644
--- a/lib/video.c
+++ b/lib/video.c
@@ -430,14 +430,7 @@ void libvlc_video_set_crop_geometry( libvlc_media_player_t *p_mi,
     for (size_t i = 0; i < n; i++)
     {
         vout_thread_t *p_vout = pp_vouts[i];
-        vlc_value_t val;
-
-        /* Make sure the geometry is in the choice list */
-        /* Earlier choices are removed to not grow a long list over time. */
-        /* FIXME: not atomic - lock? */
-        val.psz_string = (char *)psz_geometry;
-        var_Change (p_vout, "crop", VLC_VAR_CLEARCHOICES, NULL, NULL);
-        var_Change (p_vout, "crop", VLC_VAR_ADDCHOICE, &val, &val);
+
         var_SetString (p_vout, "crop", psz_geometry);
         vlc_object_release (p_vout);
     }



More information about the vlc-commits mailing list