[vlc-commits] macosx: Fix warning about incorrect usage of negator

David Fuhrmann git at videolan.org
Tue Sep 27 08:11:06 CEST 2016


vlc/vlc-2.2 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Tue Sep 27 08:10:26 2016 +0200| [586b781174d08be8a0a580816c6e9bc3f677c47f] | committer: David Fuhrmann

macosx: Fix warning about incorrect usage of negator

Not cherry picked from 88b85b54fc0e65b4cdafa2d43cd5fd6283d61bcb

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=586b781174d08be8a0a580816c6e9bc3f677c47f
---

 modules/gui/macosx/ConvertAndSave.m | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/gui/macosx/ConvertAndSave.m b/modules/gui/macosx/ConvertAndSave.m
index 2f6fe9e..d436086 100644
--- a/modules/gui/macosx/ConvertAndSave.m
+++ b/modules/gui/macosx/ConvertAndSave.m
@@ -481,21 +481,21 @@ static VLCConvertAndSave *_o_sharedInstance = nil;
     [labelContent release];
 
     /* catch obvious errors */
-    if (![[_stream_address_fld stringValue] length] > 0) {
+    if ([[_stream_address_fld stringValue] length] == 0) {
         NSBeginInformationalAlertSheet(_NS("No Address given"),
                                        _NS("OK"), @"", @"", _stream_panel, nil, nil, nil, nil,
                                        @"%@", _NS("In order to stream, a valid destination address is required."));
         return;
     }
 
-    if ([_stream_sap_ckb state] && ![[_stream_channel_fld stringValue] length] > 0) {
+    if ([_stream_sap_ckb state] && [[_stream_channel_fld stringValue] length] == 0) {
         NSBeginInformationalAlertSheet(_NS("No Channel Name given"),
                                        _NS("OK"), @"", @"", _stream_panel, nil, nil, nil, nil,
                                        @"%@", _NS("SAP stream announcement is enabled. However, no channel name is provided."));
         return;
     }
 
-    if ([_stream_sdp_matrix isEnabled] && [_stream_sdp_matrix selectedCell] != [_stream_sdp_matrix cellWithTag:0] && ![[_stream_sdp_fld stringValue] length] > 0) {
+    if ([_stream_sdp_matrix isEnabled] && [_stream_sdp_matrix selectedCell] != [_stream_sdp_matrix cellWithTag:0] && [[_stream_sdp_fld stringValue] length] == 0) {
         NSBeginInformationalAlertSheet(_NS("No SDP URL given"),
                                        _NS("OK"), @"", @"", _stream_panel, nil, nil, nil, nil,
                                        @"%@", _NS("A SDP export is requested, but no URL is provided."));



More information about the vlc-commits mailing list