[vlc-commits] http: Fix use of uninitialized value

Hugo Beauzée-Luyssen git at videolan.org
Tue Apr 4 15:37:47 CEST 2017


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Apr  4 15:31:48 2017 +0200| [691be57a8e281f9283cb3c33b3125da672a7b753] | committer: Hugo Beauzée-Luyssen

http: Fix use of uninitialized value

http2 wasn't initialized, but was probed in both vlc_http(s)_functions,
yielding undefined behavior

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=691be57a8e281f9283cb3c33b3125da672a7b753
---

 modules/access/http/connmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/access/http/connmgr.c b/modules/access/http/connmgr.c
index 92ef56e..6a1f0f0 100644
--- a/modules/access/http/connmgr.c
+++ b/modules/access/http/connmgr.c
@@ -147,7 +147,7 @@ static struct vlc_http_msg *vlc_https_request(struct vlc_http_mgr *mgr,
                                               const struct vlc_http_msg *req)
 {
     vlc_tls_t *tls;
-    bool http2;
+    bool http2 = true;
 
     if (mgr->creds == NULL && mgr->conn != NULL)
         return NULL; /* switch from HTTP to HTTPS not implemented */



More information about the vlc-commits mailing list