[vlc-commits] mp4: Fix use after free

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Fri Apr 28 13:23:36 2017 +0200| [e6a3b00b02c90f2e52bba530da736d3079d40626] | committer: Hugo Beauzée-Luyssen

mp4: Fix use after free

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e6a3b00b02c90f2e52bba530da736d3079d40626
---

 modules/demux/mp4/mp4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/demux/mp4/mp4.c b/modules/demux/mp4/mp4.c
index 1d342b35f2..8d04635afe 100644
--- a/modules/demux/mp4/mp4.c
+++ b/modules/demux/mp4/mp4.c
@@ -1949,7 +1949,6 @@ static void Close ( vlc_object_t * p_this )
     {
         MP4_TrackDestroy( p_demux, &p_sys->track[i_track] );
     }
-    free( p_sys->track );
 
     if( p_sys->p_title )
         vlc_input_title_Delete( p_sys->p_title );
@@ -1958,6 +1957,7 @@ static void Close ( vlc_object_t * p_this )
 
     LeafResetContext( p_sys );
 
+    free( p_sys->track );
     free( p_sys );
 }