[vlc-commits] ttml: remove nonsensical pointer cast

Rémi Denis-Courmont git at videolan.org
Sun Apr 30 18:21:18 CEST 2017


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Apr 30 19:17:43 2017 +0300| [66d0d3fffd8c4a8ec7ef309323af1ac9f3b1b2b7] | committer: Rémi Denis-Courmont

ttml: remove nonsensical pointer cast

The difference between the integer representation of two pointers has
no particular meaning in general (the result is platform-dependent),
other than zero meaning equality. It is only really useful when dealing
with data alignment.

In this case, both operands point into the same object, so the pointer
difference is well-defined anyhow.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=66d0d3fffd8c4a8ec7ef309323af1ac9f3b1b2b7
---

 modules/demux/ttml.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/demux/ttml.c b/modules/demux/ttml.c
index 6e9fc8e327..6c81292bc4 100644
--- a/modules/demux/ttml.c
+++ b/modules/demux/ttml.c
@@ -451,7 +451,7 @@ int OpenDemux( vlc_object_t* p_this )
         for( size_t i=0; i<ARRAY_SIZE(rgsz) && !psz_ns; i++ )
         {
             psz_ns = strnstr( psz_xml, rgsz[i],
-                              i_xml -( (ptrdiff_t)psz_tt - (ptrdiff_t)psz_xml ) );
+                              i_xml - (psz_tt - psz_xml) );
         }
         free( psz_alloc );
         if( !psz_ns )



More information about the vlc-commits mailing list