[vlc-commits] vout core: drop invalid palette

[Francois Cartegnie]

vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Wed Aug  2 16:07:40 2017 +0200| [6b7b7920530e273ee4869d034b99cc59c5263d0f] | committer: Jean-Baptiste Kempf

vout core: drop invalid palette

This fixes numerous DVD issues with menus reported

Close #18303

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6b7b7920530e273ee4869d034b99cc59c5263d0f
---

 src/video_output/vout_subpictures.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/video_output/vout_subpictures.c b/src/video_output/vout_subpictures.c
index 8a021fc18d..5a72a3a06b 100644
--- a/src/video_output/vout_subpictures.c
+++ b/src/video_output/vout_subpictures.c
@@ -763,15 +763,11 @@ static void SpuRenderRegion(spu_t *spu,
             changed_palette = true;
         }
 
-        /* Patch fully transparent broken palette for cropping */
-        if( !b_opaque )
-        {
-            new_palette.palette[1][3] = 0x0f;
-            new_palette.palette[2][3] = 0x0f;
-            new_palette.palette[3][3] = 0x0f;
-        }
+        /* Reject fully transparent broken palette for cropping */
+        changed_palette &= b_opaque;
 
-        *old_palette = new_palette;
+        if( changed_palette )
+            *old_palette = new_palette;
     }
 
     /* */