[vlc-commits] avoid crash in imem.c plugin

[Abylay Ospan]

vlc | branch: master | Abylay Ospan <aospan at netup.ru> | Wed Aug 23 15:54:05 2017 -0400| [aed5355643622a57ad8ab6ea7f8f3c6eae000a28] | committer: Rémi Denis-Courmont

avoid crash in imem.c plugin

p_sys is allocated using vlc_calloc but deleted by regular 'free' call.
This cause 'double free or corruption' crash.
do not delete p_sys here because it will be automatically deallocated by
'vlc_objres_clear' in modules.c

Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=aed5355643622a57ad8ab6ea7f8f3c6eae000a28
---

 modules/access/imem.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/access/imem.c b/modules/access/imem.c
index d98e764bb6..3496f8a1a9 100644
--- a/modules/access/imem.c
+++ b/modules/access/imem.c
@@ -257,7 +257,6 @@ static int OpenCommon(vlc_object_t *object, imem_sys_t **sys_ptr, const char *ps
 
     if (!sys->source.get || !sys->source.release) {
         msg_Err(object, "Invalid get/release function pointers");
-        free(sys);
         return VLC_EGENERIC;
     }