[vlc-commits] demux: ogg: fix broken fix

Francois Cartegnie git at videolan.org
Wed Feb 15 11:15:35 CET 2017


vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Wed Feb 15 11:14:03 2017 +0100| [92361e7c62b99f88f1d50cb3f00bc01bc49c2b82] | committer: Francois Cartegnie

demux: ogg: fix broken fix

vorbis structs being allocated by demux itself, now leaks

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=92361e7c62b99f88f1d50cb3f00bc01bc49c2b82
---

 modules/demux/ogg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/demux/ogg.c b/modules/demux/ogg.c
index 37d485a..40f1160 100644
--- a/modules/demux/ogg.c
+++ b/modules/demux/ogg.c
@@ -2228,10 +2228,10 @@ static void Ogg_CleanSpecificData( logical_stream_t *p_stream )
     {
         if( p_stream->special.vorbis.p_info )
             vorbis_info_clear( p_stream->special.vorbis.p_info );
-        p_stream->special.vorbis.p_info = NULL;
+        FREENULL( p_stream->special.vorbis.p_info );
         if( p_stream->special.vorbis.p_comment )
             vorbis_comment_clear( p_stream->special.vorbis.p_comment );
-        p_stream->special.vorbis.p_comment = NULL;
+        FREENULL( p_stream->special.vorbis.p_comment );
         p_stream->special.vorbis.i_headers_flags = 0;
     }
 #else



More information about the vlc-commits mailing list