[vlc-commits] gui/qt: extended_panels: ChangeVFiltersString: NULL check

[Filip Roséen]

vlc | branch: master | Filip Roséen <filip at atch.se> | Sat Feb 25 07:31:45 2017 +0100| [0a92e09c2995eb62ba62f45ba2201856c85a2341] | committer: Jean-Baptiste Kempf

gui/qt: extended_panels: ChangeVFiltersString: NULL check

GetVFilterType returns NULL on error, meaning that it is not
guaranteed that psz_filter_type contains what we require: this change
make sure that we abort ChangeVFiltersString if the type is unknown.

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0a92e09c2995eb62ba62f45ba2201856c85a2341
---

 modules/gui/qt/components/extended_panels.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/modules/gui/qt/components/extended_panels.cpp b/modules/gui/qt/components/extended_panels.cpp
index 6a9c947..e1469ba 100644
--- a/modules/gui/qt/components/extended_panels.cpp
+++ b/modules/gui/qt/components/extended_panels.cpp
@@ -306,6 +306,9 @@ static void ChangeVFiltersString( struct intf_thread_t *p_intf, const char *psz_
 {
     const char *psz_filter_type = GetVFilterType( p_intf, psz_name );
 
+    if( psz_filter_type == NULL )
+        return;
+
     QString result = ChangeFiltersString( p_intf, psz_filter_type, psz_name, b_add );
 
     /* Vout is not kept, so put that in the config */