[vlc-commits] video_filter:edgedetection: no need for an intermediate variable

Steve Lhomme git at videolan.org
Thu Jul 13 11:10:31 CEST 2017


vlc | branch: master | Steve Lhomme <robux4 at videolabs.io> | Tue Jul 11 11:41:08 2017 +0200| [6b82bfddd201f123d38dcae5631da48f9753c692] | committer: Jean-Baptiste Kempf

video_filter:edgedetection: no need for an intermediate variable

the value is forced later in the code

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6b82bfddd201f123d38dcae5631da48f9753c692
---

 modules/video_filter/edgedetection.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/video_filter/edgedetection.c b/modules/video_filter/edgedetection.c
index bea5010f9a..54a960ba48 100644
--- a/modules/video_filter/edgedetection.c
+++ b/modules/video_filter/edgedetection.c
@@ -94,7 +94,6 @@ struct filter_sys_t
 static int Open( vlc_object_t *p_this )
 {
     int i_ret;
-    es_format_t fmt;
     filter_t *p_filter = (filter_t *)p_this;
     filter_owner_t owner = {
         .sys = p_filter,
@@ -111,9 +110,8 @@ static int Open( vlc_object_t *p_this )
         free( p_filter->p_sys );
         return VLC_EGENERIC;
     }
-    es_format_Copy( &fmt, &p_filter->fmt_in );
     /* Clear filter chain */
-    filter_chain_Reset( (filter_chain_t *)p_filter->p_sys, &p_filter->fmt_in, &fmt);
+    filter_chain_Reset( (filter_chain_t *)p_filter->p_sys, &p_filter->fmt_in, &p_filter->fmt_in);
     /* Add adjust filter to turn frame black-and-white */
     i_ret = filter_chain_AppendFromString( (filter_chain_t *)p_filter->p_sys,
                                            "adjust{saturation=0}" );



More information about the vlc-commits mailing list