[vlc-commits] contrib: Do not hardcode compiler variables for macOS

David Fuhrmann git at videolan.org
Mon Jul 17 19:25:12 CEST 2017


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sun Jul  9 18:53:09 2017 +0200| [10a4c50312dd41aadc991ef6cee940bdd675986c] | committer: David Fuhrmann

contrib: Do not hardcode compiler variables for macOS

Removal of those variables is done for multiple reasons:
- In general, the caller should set correct variables for compilers,
  this should not be done by the script itself
- In recent macOS versions, default stubs for compilers exist
  (/usr/bin/clang / gcc / cc), so there is not need to use xcrun
  anymore
- Some contribs fail to build with the multi-command notion given by
  xcrun cc, instead they are looking for a tool named "xcrun cc"
  which does not exist

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=10a4c50312dd41aadc991ef6cee940bdd675986c
---

 contrib/src/main.mak | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/contrib/src/main.mak b/contrib/src/main.mak
index e95b789a92..79cf780d23 100644
--- a/contrib/src/main.mak
+++ b/contrib/src/main.mak
@@ -111,12 +111,6 @@ endif
 
 ifdef HAVE_MACOSX
 MIN_OSX_VERSION=10.7
-CC=xcrun cc
-CXX=xcrun c++
-AR=xcrun ar
-LD=xcrun ld
-STRIP=xcrun strip
-RANLIB=xcrun ranlib
 EXTRA_CFLAGS += -isysroot $(MACOSX_SDK) -mmacosx-version-min=$(MIN_OSX_VERSION) -DMACOSX_DEPLOYMENT_TARGET=$(MIN_OSX_VERSION)
 EXTRA_CXXFLAGS += -stdlib=libc++
 EXTRA_LDFLAGS += -Wl,-syslibroot,$(MACOSX_SDK) -mmacosx-version-min=$(MIN_OSX_VERSION) -isysroot $(MACOSX_SDK) -DMACOSX_DEPLOYMENT_TARGET=$(MIN_OSX_VERSION)



More information about the vlc-commits mailing list