[vlc-commits] marq: remove wrong x offset

Victorien Le Couviour--Tuffet git at videolan.org
Tue Jun 27 16:22:03 CEST 2017


vlc | branch: master | Victorien Le Couviour--Tuffet <victorien.lecouviour.tuffet at gmail.com> | Tue Jun 27 16:16:26 2017 +0200| [0b6a543ec94c682e7bd4f717e037adacf0cdae69] | committer: Thomas Guillem

marq: remove wrong x offset

This value is used as an unsigned in the vout and therefore causes an overflow
when the alignement contains SUBPICTURE_ALIGN_LEFT, which as the result of
having a text displayed at 426xxx in x. This value is supposed to be the
relative position from the alignement, and should therefore be 0 (as it always
is when opening the module and retrieving the alignement).

Signed-off-by: Thomas Guillem <thomas at gllm.fr>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0b6a543ec94c682e7bd4f717e037adacf0cdae69
---

 modules/spu/marq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/spu/marq.c b/modules/spu/marq.c
index 28c04f8a35..1af990c884 100644
--- a/modules/spu/marq.c
+++ b/modules/spu/marq.c
@@ -421,7 +421,6 @@ static int MarqueeCallback( vlc_object_t *p_this, char const *psz_var,
     /* willing to accept a match against marq-pos */
     {
         p_sys->i_pos = newval.i_int;
-        p_sys->i_xoff = -1;       /* force to relative positioning */
     }
 
     free( p_sys->message );



More information about the vlc-commits mailing list