[vlc-commits] coreaudio: decrease circular buffer size

Thomas Guillem git at videolan.org
Thu Mar 2 18:16:53 CET 2017


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Mar  2 16:31:25 2017 +0100| [a18d209cdb898c99d8a587cea97d72bb0472817e] | committer: Thomas Guillem

coreaudio: decrease circular buffer size

Set it to AOUT_MAX_ADVANCE_TIME (3 seconds) instead of 4 seconds. It's now safe
to decrease the circular buffer size as we don't drop blocks from Play() if the
circular buffer is full.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a18d209cdb898c99d8a587cea97d72bb0472817e
---

 modules/audio_output/coreaudio_common.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/audio_output/coreaudio_common.c b/modules/audio_output/coreaudio_common.c
index 7470ffa..4bff750 100644
--- a/modules/audio_output/coreaudio_common.c
+++ b/modules/audio_output/coreaudio_common.c
@@ -30,8 +30,6 @@
 #import <vlc_dialog.h>
 #endif
 
-#define AUDIO_BUFFER_SIZE_IN_SECONDS ((AOUT_MAX_ADVANCE_TIME + CLOCK_FREQ) / CLOCK_FREQ)
-
 static inline uint64_t
 BytesToFrames(struct aout_sys_common *p_sys, size_t i_bytes)
 {
@@ -700,7 +698,7 @@ au_Initialize(audio_output_t *p_aout, AudioUnit au, audio_sample_format_t *fmt,
         return VLC_EGENERIC;
     }
 
-    ret = ca_Initialize(p_aout, fmt, AUDIO_BUFFER_SIZE_IN_SECONDS *
+    ret = ca_Initialize(p_aout, fmt, AOUT_MAX_ADVANCE_TIME / CLOCK_FREQ *
                         fmt->i_rate * fmt->i_bytes_per_frame);
     if (ret != VLC_SUCCESS)
     {



More information about the vlc-commits mailing list