[vlc-commits] demux/playlist/podcast: fix usage of wrong variable in if-condition

[Filip Roséen]

vlc | branch: master | Filip Roséen <filip at atch.se> | Wed Mar 15 10:06:53 2017 +0100| [bfcb8e3c87f624de42a7d9d44064a23ed8dbf20d] | committer: Hugo Beauzée-Luyssen

demux/playlist/podcast: fix usage of wrong variable in if-condition

The relevant if-statement is meant to abort parsing if strdup fails,
and should therfore check the value of "psz_elname" (as node is always
not-NULL on the line in question).

Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bfcb8e3c87f624de42a7d9d44064a23ed8dbf20d
---

 modules/demux/playlist/podcast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/demux/playlist/podcast.c b/modules/demux/playlist/podcast.c
index 4e3d47d..e5a30e8 100644
--- a/modules/demux/playlist/podcast.c
+++ b/modules/demux/playlist/podcast.c
@@ -114,7 +114,7 @@ static int Demux( demux_t *p_demux )
             {
                 free( psz_elname );
                 psz_elname = strdup( node );
-                if( unlikely(!node) )
+                if( unlikely(!psz_elname) )
                     goto error;
 
                 if( !strcmp( node, "item" ) )