[vlc-commits] gui/qt: dialogs/plugins: remove extraneous parentheses to silence warning

Filip Roséen git at videolan.org
Wed Mar 15 19:19:24 CET 2017


vlc | branch: master | Filip Roséen <filip at atch.se> | Wed Mar 15 10:07:42 2017 +0100| [1b486afded527b096bb753d9aa5a046df0bb070e] | committer: Hugo Beauzée-Luyssen

gui/qt: dialogs/plugins: remove extraneous parentheses to silence warning

The code of course works as it should, but llvm will spit out a
warning diagnostic due to extraneous parenthesis (thinking that it
probably should be "=" instead of "==").

Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1b486afded527b096bb753d9aa5a046df0bb070e
---

 modules/gui/qt/dialogs/plugins.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/gui/qt/dialogs/plugins.cpp b/modules/gui/qt/dialogs/plugins.cpp
index 9e05b08..4e8d273 100644
--- a/modules/gui/qt/dialogs/plugins.cpp
+++ b/modules/gui/qt/dialogs/plugins.cpp
@@ -1346,7 +1346,7 @@ void AddonItemDelegate::editButtonClicked()
     QWidget *editor = qobject_cast<QWidget *>(sender()->parent());
     if ( !editor ) return;
     int value = editor->property("Addon::state").toInt();
-    if ( ( value == ADDON_INSTALLED ) )
+    if ( value == ADDON_INSTALLED )
         /* uninstall */
         editor->setProperty("Addon::state", ADDON_UNINSTALLING );
     else



More information about the vlc-commits mailing list