[vlc-commits] gui/qt: remove unnecessary forward declarations in global scope

Filip Roséen git at videolan.org
Mon Mar 20 13:53:07 CET 2017


vlc | branch: master | Filip Roséen <filip at atch.se> | Mon Mar 20 13:41:58 2017 +0100| [4baafadc5278bb6d8ae220bd9400f812ef0d0db6] | committer: Hugo Beauzée-Luyssen

gui/qt: remove unnecessary forward declarations in global scope

Given that these identifiers are only necessary for the data-member
declarations within struct intf_sys_t, it is preferred to simply use
elaborated type specifiers (the semantics are equivalent).

Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4baafadc5278bb6d8ae220bd9400f812ef0d0db6
---

 modules/gui/qt/qt.hpp | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/modules/gui/qt/qt.hpp b/modules/gui/qt/qt.hpp
index 15dea9f..569945e 100644
--- a/modules/gui/qt/qt.hpp
+++ b/modules/gui/qt/qt.hpp
@@ -68,22 +68,14 @@ enum{
     NOTIFICATION_ALWAYS = 2,
 };
 
-class QVLCApp;
-class MainInterface;
-class QSettings;
-class PLModel;
-
 struct intf_sys_t
 {
     vlc_thread_t thread;
 
-    QVLCApp *p_app;          /* Main Qt Application */
-
-    MainInterface *p_mi;     /* Main Interface, NULL if DialogProvider Mode */
-
-    QSettings *mainSettings; /* Qt State settings not messing main VLC ones */
-
-    PLModel *pl_model;
+    class QVLCApp *p_app;          /* Main Qt Application */
+    class MainInterface *p_mi;     /* Main Interface, NULL if DialogProvider Mode */
+    class QSettings *mainSettings; /* Qt State settings not messing main VLC ones */
+    class PLModel *pl_model;
 
     QString filepath;        /* Last path used in dialogs */
 



More information about the vlc-commits mailing list