[vlc-commits] qt: fix usage of a released aout object

Thomas Guillem git at videolan.org
Wed May 31 17:45:09 CEST 2017


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Wed May 31 17:28:37 2017 +0200| [3ed8da62e429b76ab9d5a127c982b55d4e466690] | committer: Thomas Guillem

qt: fix usage of a released aout object

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3ed8da62e429b76ab9d5a127c982b55d4e466690
---

 modules/gui/qt/components/extended_panels.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/modules/gui/qt/components/extended_panels.cpp b/modules/gui/qt/components/extended_panels.cpp
index 7ce4c4f782..9080238393 100644
--- a/modules/gui/qt/components/extended_panels.cpp
+++ b/modules/gui/qt/components/extended_panels.cpp
@@ -1188,10 +1188,7 @@ void Equalizer::build()
     vlc_object_t *p_aout = (vlc_object_t *)THEMIM->getAout();
     char *psz_af;
     if( p_aout )
-    {
         psz_af = var_GetNonEmptyString( p_aout, "audio-filter" );
-        vlc_object_release( p_aout );
-    }
     else
         psz_af = var_InheritString( THEPL, "audio-filter" );
 
@@ -1219,6 +1216,8 @@ void Equalizer::build()
     /* Connect and set 2 Pass checkbox */
     ui.eq2PassCheck->setChecked( var_InheritBool( p_aout, "equalizer-2pass" ) );
     CONNECT( ui.eq2PassCheck, toggled(bool), this, enable2Pass(bool) );
+    if( p_aout )
+        vlc_object_release( p_aout );
 }
 
 void Equalizer::setSaveToConfig( bool b_save )



More information about the vlc-commits mailing list