[vlc-commits] dsm: fix login dialog not shown if only a username was given

[Thomas Guillem]

vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Nov  2 10:22:51 2017 +0100| [5430ac165ca97ec873957d6ee9eab1c2d7fa3a38] | committer: Thomas Guillem

dsm: fix login dialog not shown if only a username was given

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5430ac165ca97ec873957d6ee9eab1c2d7fa3a38
---

 modules/access/dsm/access.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/modules/access/dsm/access.c b/modules/access/dsm/access.c
index f97d488dbb..2e5cea9f7b 100644
--- a/modules/access/dsm/access.c
+++ b/modules/access/dsm/access.c
@@ -295,14 +295,6 @@ static int smb_connect( stream_t *p_access, const char *psz_login,
         return VLC_EGENERIC;
 }
 
-static bool smb_has_invalid_creds( stream_t *p_access )
-{
-    access_sys_t *p_sys = p_access->p_sys;
-    uint32_t i_nt_status = smb_session_get_nt_status( p_sys->p_session );
-
-    return i_nt_status & (NT_STATUS_ACCESS_DENIED | NT_STATUS_LOGON_FAILURE);
-}
-
 /* Performs login with existing credentials and ask the user for new ones on
    failure */
 static int login( stream_t *p_access )
@@ -338,8 +330,7 @@ static int login( stream_t *p_access )
     if( smb_connect( p_access, psz_login, psz_password, psz_domain )
                      != VLC_SUCCESS )
     {
-        while( smb_has_invalid_creds( p_access)
-            && vlc_credential_get( &credential, p_access, "smb-user", "smb-pwd",
+        while( vlc_credential_get( &credential, p_access, "smb-user", "smb-pwd",
                                    SMB_LOGIN_DIALOG_TITLE,
                                    SMB_LOGIN_DIALOG_TEXT, p_sys->netbios_name ) )
         {