[vlc-commits] ci_filters: build with -Wpartial-availability

Thomas Guillem git at videolan.org
Tue Nov 21 14:44:18 CET 2017


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Tue Nov 21 14:06:18 2017 +0100| [645537b8ae9b42a829021a53dd165282a0434547] | committer: Thomas Guillem

ci_filters: build with -Wpartial-availability

Symbols availability are checked at entry point.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=645537b8ae9b42a829021a53dd165282a0434547
---

 modules/video_filter/Makefile.am  | 1 +
 modules/video_filter/ci_filters.m | 6 ------
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/modules/video_filter/Makefile.am b/modules/video_filter/Makefile.am
index af190d16e3..6b2947a19b 100644
--- a/modules/video_filter/Makefile.am
+++ b/modules/video_filter/Makefile.am
@@ -116,6 +116,7 @@ video_filter_LTLIBRARIES += libci_filters_plugin.la
 endif
 
 if HAVE_IOS
+libci_filters_plugin_la_OBJCFLAGS = $(AM_OBJCFLAGS) -Wpartial-availability
 video_filter_LTLIBRARIES += libci_filters_plugin.la
 endif
 
diff --git a/modules/video_filter/ci_filters.m b/modules/video_filter/ci_filters.m
index 0bc401819c..5f2089436f 100644
--- a/modules/video_filter/ci_filters.m
+++ b/modules/video_filter/ci_filters.m
@@ -606,10 +606,7 @@ Open(vlc_object_t *obj, char const *psz_filter)
         case VLC_CODEC_CVPX_UYVY:
         case VLC_CODEC_CVPX_I420:
         case VLC_CODEC_CVPX_BGRA:
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wpartial-availability"
             if (&kCGColorSpaceITUR_709 == nil)
-#pragma clang diagnostic pop
             {
                 msg_Warn(obj, "iOS/macOS version is too old, aborting...");
                 return VLC_EGENERIC;
@@ -638,10 +635,7 @@ Open(vlc_object_t *obj, char const *psz_filter)
          && Open_AddConverter(filter, ctx))
             goto error;
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wpartial-availability"
         ctx->color_space = CGColorSpaceCreateWithName(kCGColorSpaceITUR_709);
-#pragma clang diagnostic pop
 
 #if !TARGET_OS_IPHONE
         CGLContextObj glctx = var_InheritAddress(filter, "macosx-glcontext");



More information about the vlc-commits mailing list