[vlc-commits] http_auth: fix potential NULL deref (fixes #18595)

Rémi Denis-Courmont git at videolan.org
Sun Oct 8 11:48:20 CEST 2017


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Oct  8 12:47:40 2017 +0300| [4222bcb93c8266ed6d612fbcbcb3dbc9cc35d67e] | committer: Rémi Denis-Courmont

http_auth: fix potential NULL deref (fixes #18595)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4222bcb93c8266ed6d612fbcbcb3dbc9cc35d67e
---

 src/network/http_auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/network/http_auth.c b/src/network/http_auth.c
index 56b2cdb494..07064ce226 100644
--- a/src/network/http_auth.c
+++ b/src/network/http_auth.c
@@ -357,7 +357,7 @@ int vlc_http_auth_ParseAuthenticationInfoHeader(
          */
         psz_digest = AuthDigest( p_this, p_auth, psz_method, psz_path,
                                  psz_username, psz_password );
-        if ( strcmp( psz_digest, psz_rspauth ) != 0 )
+        if( psz_digest == NULL || strcmp( psz_digest, psz_rspauth ) != 0 )
         {
             msg_Err( p_this, "HTTP Digest Access Authentication: server "
                              "replied with an invalid response digest "



More information about the vlc-commits mailing list