[vlc-commits] keystore: Don't reject credentials from memory/keystore without dialog params

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Fri Oct 27 09:54:12 2017 +0200| [34860e84807e8bb87c3370a108cbc5afbe5b030b] | committer: Hugo Beauzée-Luyssen

keystore: Don't reject credentials from memory/keystore without dialog params

This was preventing known credentials to be used on first connection,
causing 2 connection attempts where 1 would have been enough

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=34860e84807e8bb87c3370a108cbc5afbe5b030b
---

 src/misc/keystore.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/misc/keystore.c b/src/misc/keystore.c
index 116849e042..b754a8a74d 100644
--- a/src/misc/keystore.c
+++ b/src/misc/keystore.c
@@ -435,9 +435,6 @@ vlc_credential_get(vlc_credential *p_credential, vlc_object_t *p_parent,
 
         case GET_FROM_MEMORY_KEYSTORE:
         {
-            if (!psz_dialog_title || !psz_dialog_fmt)
-                return false;
-
             vlc_keystore *p_keystore = get_memory_keystore(p_parent);
             if (p_keystore != NULL)
                 credential_find_keystore(p_credential, p_keystore);
@@ -446,9 +443,6 @@ vlc_credential_get(vlc_credential *p_credential, vlc_object_t *p_parent,
         }
 
         case GET_FROM_KEYSTORE:
-            if (!psz_dialog_title || !psz_dialog_fmt)
-                return false;
-
             if (p_credential->p_keystore == NULL)
                 p_credential->p_keystore = vlc_keystore_create(p_parent);
             if (p_credential->p_keystore != NULL)