[vlc-commits] access: file: don't display error dialogs

Thomas Guillem git at videolan.org
Tue Sep 19 16:01:05 CEST 2017


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Tue Sep 19 15:58:28 2017 +0200| [8aeb66fe635763b72fd35c977892ec7897a53984] | committer: Thomas Guillem

access: file: don't display error dialogs

A general error dialog is already displayed by the core in input.c (see "Your
input can't be opened") in case of error.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=8aeb66fe635763b72fd35c977892ec7897a53984
---

 modules/access/file.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/modules/access/file.c b/modules/access/file.c
index dc9f0d69f9..938b1369e8 100644
--- a/modules/access/file.c
+++ b/modules/access/file.c
@@ -57,7 +57,6 @@
 #include "fs.h"
 #include <vlc_input.h>
 #include <vlc_access.h>
-#include <vlc_dialog.h>
 #ifdef _WIN32
 # include <vlc_charset.h>
 #endif
@@ -174,11 +173,6 @@ int FileOpen( vlc_object_t *p_this )
                  p_access->psz_filepath ? p_access->psz_filepath
                                         : p_access->psz_location,
                  vlc_strerror_c(errno));
-        vlc_dialog_display_error (p_access, _("File reading failed"),
-            _("VLC could not open the file \"%s\" (%s)."),
-            p_access->psz_filepath ? p_access->psz_filepath
-                                   : p_access->psz_location,
-            vlc_strerror(errno));
         return VLC_EGENERIC;
     }
 
@@ -287,9 +281,6 @@ static ssize_t Read (stream_t *p_access, void *p_buffer, size_t i_len)
         }
 
         msg_Err (p_access, "read error: %s", vlc_strerror_c(errno));
-        vlc_dialog_display_error (p_access, _("File reading failed"),
-            _("VLC could not read the file (%s)."),
-            vlc_strerror(errno));
         val = 0;
     }
 



More information about the vlc-commits mailing list