[vlc-commits] core: remove global *_sys_t typedefs

Romain Vimont git at videolan.org
Mon Apr 30 13:48:18 CEST 2018


vlc | branch: master | Romain Vimont <rom1v at videolabs.io> | Fri Apr 27 22:10:57 2018 +0200| [db50540ed481d6c11fe7c947fcb9b3a2ad574c37] | committer: Jean-Baptiste Kempf

core: remove global *_sys_t typedefs

Do not declare *_sys_t typedefs globally in vlc_common.h. Instead,
declare them locally in each module that provides a definition.

This paves the way to move C++ definitions into anonymous namespaces in
order to respect C++ ODR.

The picture_resource_t and sout_stream_id_sys_t typedefs will be handled
separately, since they require specific additional changes.

See #18033

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=db50540ed481d6c11fe7c947fcb9b3a2ad574c37
---

 include/vlc_common.h                                | 15 ---------------
 modules/access/alsa.c                               |  4 ++--
 modules/access/attachment.c                         |  4 ++--
 modules/access/avio.c                               |  9 +++++----
 modules/access/bluray.c                             |  9 +++++----
 modules/access/cdda.c                               |  8 ++++----
 modules/access/concat.c                             |  4 ++--
 modules/access/dc1394.c                             |  4 ++--
 modules/access/directory.c                          |  4 ++--
 modules/access/dshow/access.h                       |  4 ++++
 modules/access/dsm/sd.c                             |  4 ++--
 modules/access/dtv/access.c                         |  4 ++--
 modules/access/dv.c                                 |  4 ++--
 modules/access/dvb/access.c                         |  4 ++--
 modules/access/dvdnav.c                             |  4 ++--
 modules/access/dvdread.c                            |  4 ++--
 modules/access/file.c                               |  4 ++--
 modules/access/ftp.c                                |  3 +++
 modules/access/http.c                               |  4 ++--
 modules/access/http/access.c                        |  4 ++--
 modules/access/idummy.c                             |  4 ++--
 modules/access/imem-access.c                        |  4 ++--
 modules/access/imem.c                               |  4 ++--
 modules/access/jack.c                               |  4 ++--
 modules/access/linsys/linsys_hdsdi.c                |  4 ++--
 modules/access/linsys/linsys_sdi.c                  |  4 ++--
 modules/access/mms/mms.c                            |  4 ++--
 modules/access/mms/mmsh.h                           |  4 ++--
 modules/access/mms/mmstu.h                          |  4 ++--
 modules/access/nfs.c                                |  4 ++--
 modules/access/oss.c                                |  4 ++--
 modules/access/pulse.c                              |  4 ++--
 modules/access/rdp.c                                |  4 ++--
 modules/access/rtp/rtp.h                            |  4 ++--
 modules/access/rtsp/access.c                        |  4 ++--
 modules/access/samba.c                              |  4 ++--
 modules/access/satip.c                              |  5 +++--
 modules/access/screen/screen.h                      |  4 ++--
 modules/access/screen/wayland.c                     |  4 ++--
 modules/access/screen/xcb.c                         |  4 ++--
 modules/access/sftp.c                               |  4 ++--
 modules/access/shm.c                                |  2 ++
 modules/access/srt.c                                |  4 ++--
 modules/access/timecode.c                           |  4 ++--
 modules/access/udp.c                                |  4 ++--
 modules/access/unc.c                                |  4 ++--
 modules/access/v4l2/access.c                        |  4 ++--
 modules/access/v4l2/demux.c                         |  4 ++--
 modules/access/v4l2/radio.c                         |  4 ++--
 modules/access/vcd/vcd.c                            |  4 ++--
 modules/access/vdr.c                                |  4 ++--
 modules/access/vnc.c                                |  4 ++--
 modules/access/wasapi.c                             |  4 ++--
 modules/access_output/http.c                        |  4 ++--
 modules/access_output/livehttp.c                    |  4 ++--
 modules/access_output/shout.c                       |  4 ++--
 modules/access_output/srt.c                         |  4 ++--
 modules/access_output/udp.c                         |  4 ++--
 modules/audio_filter/audiobargraph_a.c              |  4 ++--
 modules/audio_filter/channel_mixer/dolby.c          |  4 ++--
 modules/audio_filter/channel_mixer/headphone.c      | 10 +++++-----
 modules/audio_filter/channel_mixer/mono.c           |  8 ++++----
 modules/audio_filter/channel_mixer/remap.c          |  4 ++--
 modules/audio_filter/channel_mixer/spatialaudio.cpp |  4 ++--
 modules/audio_filter/channel_mixer/trivial.c        |  4 ++--
 modules/audio_filter/chorus_flanger.c               |  2 ++
 modules/audio_filter/compressor.c                   |  4 ++--
 modules/audio_filter/converter/tospdif.c            |  4 ++--
 modules/audio_filter/equalizer.c                    |  4 ++--
 modules/audio_filter/gain.c                         |  4 ++--
 modules/audio_filter/normvol.c                      |  6 +++---
 modules/audio_filter/param_eq.c                     |  4 ++--
 modules/audio_filter/resampler/bandlimited.c        |  4 ++--
 modules/audio_filter/resampler/soxr.c               |  6 +++---
 modules/audio_filter/resampler/speex.c              |  2 +-
 modules/audio_filter/resampler/src.c                |  2 +-
 modules/audio_filter/scaletempo.c                   |  4 ++--
 modules/audio_filter/stereo_widen.c                 |  4 ++--
 modules/audio_output/alsa.c                         |  4 ++--
 modules/audio_output/amem.c                         |  4 ++--
 modules/audio_output/audiotrack.c                   |  5 +++--
 modules/audio_output/auhal.c                        |  4 ++--
 modules/audio_output/directsound.c                  |  4 ++--
 modules/audio_output/file.c                         |  4 ++--
 modules/audio_output/jack.c                         | 18 +++++++++---------
 modules/audio_output/kai.c                          |  4 ++--
 modules/audio_output/mmdevice.c                     |  4 ++--
 modules/audio_output/opensles_android.c             |  4 ++--
 modules/audio_output/oss.c                          |  4 ++--
 modules/audio_output/pulse.c                        |  4 ++--
 modules/audio_output/sndio.c                        |  4 ++--
 modules/audio_output/tizen_audio.c                  |  5 +++--
 modules/audio_output/waveout.c                      |  3 +++
 modules/audio_output/winstore.c                     |  4 ++--
 modules/codec/a52.c                                 |  4 ++--
 modules/codec/adpcm.c                               |  4 ++--
 modules/codec/aes3.c                                |  4 ++--
 modules/codec/aom.c                                 |  8 ++++----
 modules/codec/araw.c                                |  4 ++--
 modules/codec/arib/aribsub.c                        |  4 ++--
 modules/codec/audiotoolbox_midi.c                   |  4 ++--
 modules/codec/avcodec/audio.c                       |  4 ++--
 modules/codec/avcodec/encoder.c                     |  4 ++--
 modules/codec/avcodec/subtitle.c                    |  5 +++--
 modules/codec/avcodec/video.c                       |  4 ++--
 modules/codec/bpg.c                                 |  4 ++--
 modules/codec/cc.c                                  |  4 ++--
 modules/codec/cdg.c                                 |  4 ++--
 modules/codec/crystalhd.c                           |  4 ++--
 modules/codec/cvdsub.c                              |  4 ++--
 modules/codec/daala.c                               |  8 ++++----
 modules/codec/dca.c                                 |  4 ++--
 modules/codec/dmo/dmo.c                             |  8 ++++----
 modules/codec/dvbsub.c                              |  8 ++++----
 modules/codec/faad.c                                |  4 ++--
 modules/codec/fdkaac.c                              |  4 ++--
 modules/codec/flac.c                                |  8 ++++----
 modules/codec/fluidsynth.c                          |  4 ++--
 modules/codec/g711.c                                |  4 ++--
 modules/codec/gstreamer/gstdecode.c                 |  4 ++--
 modules/codec/jpeg.c                                |  8 ++++----
 modules/codec/kate.c                                |  4 ++--
 modules/codec/libass.c                              |  4 ++--
 modules/codec/libmpeg2.c                            |  4 ++--
 modules/codec/lpcm.c                                |  8 ++++----
 modules/codec/mad.c                                 |  4 ++--
 modules/codec/mft.c                                 |  4 ++--
 modules/codec/mpg123.c                              |  4 ++--
 modules/codec/oggspots.c                            |  4 ++--
 modules/codec/omxil/mediacodec.c                    |  4 ++--
 modules/codec/omxil/omxil.h                         |  4 ++--
 modules/codec/opus.c                                |  8 ++++----
 modules/codec/png.c                                 |  8 ++++----
 modules/codec/qsv.c                                 |  4 ++--
 modules/codec/rawvideo.c                            |  4 ++--
 modules/codec/schroedinger.c                        |  8 ++++----
 modules/codec/scte18.c                              |  4 ++--
 modules/codec/scte27.c                              |  5 +++--
 modules/codec/sdl_image.c                           |  4 ++--
 modules/codec/shine.c                               |  4 ++--
 modules/codec/speex.c                               |  8 ++++----
 modules/codec/spudec/spudec.h                       |  4 ++--
 modules/codec/stl.c                                 |  5 +++--
 modules/codec/subsdec.c                             |  4 ++--
 modules/codec/substx3g.c                            |  2 +-
 modules/codec/subsusf.c                             |  4 ++--
 modules/codec/svcdsub.c                             |  4 ++--
 modules/codec/svg.c                                 |  4 ++--
 modules/codec/telx.c                                |  4 ++--
 modules/codec/textst.c                              |  4 ++--
 modules/codec/theora.c                              |  8 ++++----
 modules/codec/ttml/substtml.c                       |  4 ++--
 modules/codec/twolame.c                             |  4 ++--
 modules/codec/uleaddvaudio.c                        |  4 ++--
 modules/codec/vorbis.c                              |  8 ++++----
 modules/codec/vpx.c                                 |  8 ++++----
 modules/codec/webvtt/subsvtt.c                      |  4 ++--
 modules/codec/wmafixed/wma.c                        |  4 ++--
 modules/codec/x264.c                                |  4 ++--
 modules/codec/x265.c                                |  4 ++--
 modules/codec/zvbi.c                                |  4 ++--
 modules/demux/adaptive/adaptive.cpp                 |  2 +-
 modules/demux/adaptive/plumbing/FakeESOut.cpp       |  2 +-
 modules/demux/adaptive/plumbing/SourceStream.cpp    |  2 +-
 modules/demux/aiff.c                                |  4 ++--
 modules/demux/asf/asf.c                             |  4 ++--
 modules/demux/au.c                                  |  4 ++--
 modules/demux/avformat/demux.c                      |  4 ++--
 modules/demux/avformat/mux.c                        |  4 ++--
 modules/demux/avi/avi.c                             |  4 ++--
 modules/demux/caf.c                                 |  4 ++--
 modules/demux/cdg.c                                 |  4 ++--
 modules/demux/flac.c                                |  4 ++--
 modules/demux/gme.c                                 |  4 ++--
 modules/demux/image.c                               |  4 ++--
 modules/demux/mjpeg.c                               |  4 ++--
 modules/demux/mkv/matroska_segment.hpp              |  1 +
 modules/demux/mod.c                                 |  4 ++--
 modules/demux/mp4/mp4.c                             |  4 ++--
 modules/demux/mpc.c                                 |  4 ++--
 modules/demux/mpeg/es.c                             |  4 ++--
 modules/demux/mpeg/h26x.c                           |  4 ++--
 modules/demux/mpeg/mpgv.c                           |  4 ++--
 modules/demux/mpeg/ps.c                             |  4 ++--
 modules/demux/mpeg/ts_pid.h                         |  2 ++
 modules/demux/nsv.c                                 |  4 ++--
 modules/demux/nuv.c                                 |  4 ++--
 modules/demux/ogg.h                                 |  4 ++--
 modules/demux/playlist/sgimb.c                      |  4 ++--
 modules/demux/pva.c                                 |  4 ++--
 modules/demux/rawaud.c                              |  4 ++--
 modules/demux/rawdv.c                               |  4 ++--
 modules/demux/rawvid.c                              |  4 ++--
 modules/demux/real.c                                |  4 ++--
 modules/demux/sid.cpp                               |  2 +-
 modules/demux/smf.c                                 |  4 ++--
 modules/demux/stl.c                                 |  5 +++--
 modules/demux/subtitle.c                            |  4 ++--
 modules/demux/tta.c                                 |  4 ++--
 modules/demux/ttml.c                                |  4 ++--
 modules/demux/ty.c                                  |  4 ++--
 modules/demux/vc1.c                                 |  4 ++--
 modules/demux/vobsub.c                              |  4 ++--
 modules/demux/voc.c                                 |  4 ++--
 modules/demux/wav.c                                 |  4 ++--
 modules/demux/webvtt.c                              |  4 ++--
 modules/demux/xa.c                                  |  4 ++--
 modules/hw/d3d11/d3d11_deinterlace.c                |  4 ++--
 modules/hw/d3d11/d3d11_filters.c                    |  4 ++--
 modules/hw/d3d11/d3d11_surface.c                    |  5 +++--
 modules/hw/d3d9/d3d9_filters.c                      |  4 ++--
 modules/hw/d3d9/dxa9.c                              |  5 +++--
 modules/hw/d3d9/dxva2_deinterlace.c                 |  4 ++--
 modules/hw/mmal/codec.c                             |  5 +++--
 modules/hw/mmal/deinterlace.c                       |  5 +++--
 modules/hw/vaapi/chroma.c                           |  4 ++--
 modules/hw/vaapi/filters.c                          |  4 ++--
 modules/hw/vdpau/adjust.c                           |  4 ++--
 modules/hw/vdpau/chroma.c                           |  4 ++--
 modules/hw/vdpau/deinterlace.c                      |  4 ++--
 modules/hw/vdpau/sharpen.c                          |  4 ++--
 modules/lua/services_discovery.c                    |  4 ++--
 modules/misc/rtsp.c                                 |  4 ++--
 modules/misc/stats.c                                |  4 ++--
 modules/misc/xml/libxml.c                           |  4 ++--
 modules/mux/asf.c                                   |  4 ++--
 modules/mux/avi.c                                   |  4 ++--
 modules/mux/dummy.c                                 |  4 ++--
 modules/mux/mp4/mp4.c                               |  4 ++--
 modules/mux/mpeg/ps.c                               |  4 ++--
 modules/mux/mpeg/ts.c                               |  4 ++--
 modules/mux/ogg.c                                   |  4 ++--
 modules/mux/wav.c                                   |  4 ++--
 modules/packetizer/a52.c                            |  4 ++--
 modules/packetizer/avparser.c                       |  4 ++--
 modules/packetizer/copy.c                           |  4 ++--
 modules/packetizer/dts.c                            |  4 ++--
 modules/packetizer/flac.c                           |  4 ++--
 modules/packetizer/h264.c                           |  4 ++--
 modules/packetizer/hevc.c                           |  4 ++--
 modules/packetizer/mlp.c                            |  4 ++--
 modules/packetizer/mpeg4audio.c                     |  4 ++--
 modules/packetizer/mpeg4video.c                     |  4 ++--
 modules/packetizer/mpegaudio.c                      |  4 ++--
 modules/packetizer/mpegvideo.c                      |  4 ++--
 modules/packetizer/vc1.c                            |  4 ++--
 modules/services_discovery/avahi.c                  |  4 ++--
 modules/services_discovery/mediadirs.c              |  4 ++--
 modules/services_discovery/microdns.c               |  4 ++--
 modules/services_discovery/mtp.c                    |  4 ++--
 modules/services_discovery/podcast.c                |  4 ++--
 modules/services_discovery/pulse.c                  |  4 ++--
 modules/services_discovery/sap.c                    |  8 ++++----
 modules/services_discovery/udev.c                   |  4 ++--
 modules/services_discovery/xcb_apps.c               |  4 ++--
 modules/spu/audiobargraph_v.c                       |  4 ++--
 modules/spu/dynamicoverlay/dynamicoverlay.h         |  4 ++--
 modules/spu/logo.c                                  |  4 ++--
 modules/spu/marq.c                                  |  4 ++--
 modules/spu/mosaic.c                                |  4 ++--
 modules/spu/remoteosd.c                             |  2 ++
 modules/spu/rss.c                                   |  4 ++--
 modules/spu/subsdelay.c                             |  4 ++--
 modules/stream_filter/accesstweaks.c                |  4 ++--
 modules/stream_filter/aribcam.c                     |  4 ++--
 modules/stream_filter/cache_block.c                 |  4 ++--
 modules/stream_filter/cache_read.c                  |  4 ++--
 modules/stream_filter/decomp.c                      |  4 ++--
 modules/stream_filter/hds/hds.c                     |  4 ++--
 modules/stream_filter/inflate.c                     |  4 ++--
 modules/stream_filter/prefetch.c                    |  4 ++--
 modules/stream_filter/record.c                      |  4 ++--
 modules/stream_out/autodel.c                        |  4 ++--
 modules/stream_out/bridge.c                         |  4 ++--
 modules/stream_out/chromaprint.c                    |  4 ++--
 modules/stream_out/chromecast/chromecast_demux.cpp  |  1 -
 modules/stream_out/cycle.c                          |  4 ++--
 modules/stream_out/delay.c                          |  4 ++--
 modules/stream_out/description.c                    |  4 ++--
 modules/stream_out/display.c                        |  4 ++--
 modules/stream_out/duplicate.c                      |  4 ++--
 modules/stream_out/es.c                             |  4 ++--
 modules/stream_out/gather.c                         |  4 ++--
 modules/stream_out/mosaic_bridge.c                  |  4 ++--
 modules/stream_out/record.c                         |  4 ++--
 modules/stream_out/rtp.c                            |  6 +++---
 modules/stream_out/setid.c                          |  4 ++--
 modules/stream_out/smem.c                           |  4 ++--
 modules/stream_out/standard.c                       |  4 ++--
 modules/stream_out/stats.c                          |  4 ++--
 modules/stream_out/transcode/transcode.h            |  4 ++--
 modules/stream_out/vod.c                            |  4 ++--
 modules/text_renderer/freetype/freetype.h           |  4 ++--
 modules/text_renderer/svg.c                         |  4 ++--
 modules/video_chroma/chain.c                        |  4 ++--
 modules/video_chroma/cvpx.c                         |  4 ++--
 modules/video_chroma/i420_nv12.c                    |  4 ++--
 modules/video_chroma/i420_rgb.h                     |  4 ++--
 modules/video_chroma/swscale.c                      |  4 ++--
 modules/video_filter/adjust.c                       |  4 ++--
 modules/video_filter/alphamask.c                    |  4 ++--
 modules/video_filter/anaglyph.c                     |  4 ++--
 modules/video_filter/antiflicker.c                  |  4 ++--
 modules/video_filter/ball.c                         |  3 +++
 modules/video_filter/blendbench.c                   |  4 ++--
 modules/video_filter/bluescreen.c                   |  4 ++--
 modules/video_filter/canvas.c                       |  4 ++--
 modules/video_filter/colorthres.c                   |  4 ++--
 modules/video_filter/croppadd.c                     |  4 ++--
 modules/video_filter/deinterlace/deinterlace.h      |  4 ++--
 modules/video_filter/edgedetection.c                |  4 ++--
 modules/video_filter/erase.c                        |  4 ++--
 modules/video_filter/extract.c                      |  4 ++--
 modules/video_filter/fps.c                          |  4 ++--
 modules/video_filter/freeze.c                       |  5 +++--
 modules/video_filter/gaussianblur.c                 |  4 ++--
 modules/video_filter/gradfun.c                      |  5 +++--
 modules/video_filter/gradient.c                     |  4 ++--
 modules/video_filter/grain.c                        |  5 +++--
 modules/video_filter/hqdn3d.c                       |  4 ++--
 modules/video_filter/magnify.c                      |  4 ++--
 modules/video_filter/mirror.c                       |  4 ++--
 modules/video_filter/motionblur.c                   |  2 ++
 modules/video_filter/motiondetect.c                 |  4 ++--
 modules/video_filter/oldmovie.c                     |  5 +++--
 modules/video_filter/opencv_wrapper.c               |  4 ++--
 modules/video_filter/posterize.c                    |  4 ++--
 modules/video_filter/postproc.c                     |  4 ++--
 modules/video_filter/psychedelic.c                  |  4 ++--
 modules/video_filter/puzzle_mgt.h                   |  2 ++
 modules/video_filter/ripple.c                       |  4 ++--
 modules/video_filter/rotate.c                       |  8 ++++----
 modules/video_filter/scene.c                        |  4 ++--
 modules/video_filter/sepia.c                        |  4 ++--
 modules/video_filter/sharpen.c                      |  4 ++--
 modules/video_filter/transform.c                    |  5 +++--
 modules/video_filter/vhs.c                          |  5 +++--
 modules/video_filter/wave.c                         |  4 ++--
 modules/video_output/decklink.cpp                   |  2 +-
 modules/visualization/glspectrum.c                  |  4 ++--
 modules/visualization/goom.c                        |  4 ++--
 modules/visualization/visual/visual.c               |  4 ++--
 src/input/es_out.c                                  |  4 ++--
 src/input/es_out_timeshift.c                        |  4 ++--
 344 files changed, 752 insertions(+), 723 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=db50540ed481d6c11fe7c947fcb9b3a2ad574c37


More information about the vlc-commits mailing list