[vlc-commits] macosx: Warn about bug in VLCCoreInteraction code

[Marvin Scholz]

vlc | branch: master | Marvin Scholz <epirat07 at gmail.com> | Thu Aug  2 00:46:32 2018 +0200| [58957f42bcb429920bfdd9275695746ff141b8f9] | committer: Marvin Scholz

macosx: Warn about bug in VLCCoreInteraction code

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=58957f42bcb429920bfdd9275695746ff141b8f9
---

 modules/gui/macosx/VLCCoreInteraction.m | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/modules/gui/macosx/VLCCoreInteraction.m b/modules/gui/macosx/VLCCoreInteraction.m
index edc510e05c..6c2fa3b5ee 100644
--- a/modules/gui/macosx/VLCCoreInteraction.m
+++ b/modules/gui/macosx/VLCCoreInteraction.m
@@ -121,6 +121,11 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,
 
 - (void)dealloc
 {
+    #warning BUG! This class is a singleton, so dealloc is never called!
+    // Dealloc is never called, which not only means the below code is never
+    // run, but it means that the SPMediaKeyTap object and the AppleRemote object
+    // is not deallocated properly either.
+
     intf_thread_t *p_intf = getIntf();
     var_DelCallback(pl_Get(p_intf), "intf-boss", BossCallback, (__bridge void *)self);
     [[NSNotificationCenter defaultCenter] removeObserver: self];