[vlc-commits] vout: win32: direct3d11: fixup of d1e7dc1

[Filip Roséen]

vlc/vlc-3.0 | branch: master | Filip Roséen <filip at atch.se> | Tue Jul 31 11:58:29 2018 +0200| [7cc7c08c7f6854011b7f6627b8704b17dd939fc6] | committer: Steve Lhomme

vout: win32: direct3d11: fixup of d1e7dc1

As d1e7dc1 explicitly adds copying of the relevant fmt after the
function is called, the function itself should not be part of such
copying (to make matters worse, shallow copy is unsafe as the struct
may contain pointers to dynamically allocated resources).

fixes: #20487

Signed-off-by: Steve Lhomme <robux4 at ycbcr.xyz>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=7cc7c08c7f6854011b7f6627b8704b17dd939fc6
---

 modules/video_output/win32/direct3d11.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/video_output/win32/direct3d11.c b/modules/video_output/win32/direct3d11.c
index 8b6bc042a9..792c8e5365 100644
--- a/modules/video_output/win32/direct3d11.c
+++ b/modules/video_output/win32/direct3d11.c
@@ -1691,7 +1691,6 @@ static int SetupOutputFormat(vout_display_t *vd, video_format_t *fmt)
         Direct3D11DestroyResources(vd);
         return VLC_EGENERIC;
     }
-    vd->fmt = *fmt;
 
     return VLC_SUCCESS;
 }