[vlc-commits] ci_filters: fix null-deref

Thomas Guillem git at videolan.org
Thu Aug 9 13:29:18 CEST 2018


vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Aug  9 11:54:34 2018 +0200| [d477a1e83533665ea60a385e61c26f02b3c7c7a8] | committer: Thomas Guillem

ci_filters: fix null-deref

regression from 4c8b741e4844a80fb824caccd9606259d5958aa0

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d477a1e83533665ea60a385e61c26f02b3c7c7a8
---

 modules/video_filter/ci_filters.m | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/modules/video_filter/ci_filters.m b/modules/video_filter/ci_filters.m
index 2b928216b5..09e758cccc 100644
--- a/modules/video_filter/ci_filters.m
+++ b/modules/video_filter/ci_filters.m
@@ -587,7 +587,6 @@ static int
 Open(vlc_object_t *obj, char const *psz_filter)
 {
     filter_t *filter = (filter_t *)obj;
-    filter_sys_t *p_sys = filter->p_sys;
 
     switch (filter->fmt_in.video.i_chroma)
     {
@@ -605,7 +604,7 @@ Open(vlc_object_t *obj, char const *psz_filter)
             return VLC_EGENERIC;
     }
 
-    filter->p_sys = calloc(1, sizeof(filter_sys_t));
+    filter_sys_t *p_sys = filter->p_sys = calloc(1, sizeof(filter_sys_t));
     if (!filter->p_sys)
         return VLC_ENOMEM;
 



More information about the vlc-commits mailing list