[vlc-commits] picture_pool: remove picture_pool_Enum()

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Dec 12 22:00:17 2018 +0200| [119aca122f7802579a061f716476bd5bd0db2bf3] | committer: Rémi Denis-Courmont

picture_pool: remove picture_pool_Enum()

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=119aca122f7802579a061f716476bd5bd0db2bf3
---

 include/vlc_picture_pool.h | 14 --------------
 src/libvlccore.sym         |  1 -
 src/misc/picture_pool.c    |  9 ---------
 3 files changed, 24 deletions(-)

diff --git a/include/vlc_picture_pool.h b/include/vlc_picture_pool.h
index 8b04370bfb..0fef08ec63 100644
--- a/include/vlc_picture_pool.h
+++ b/include/vlc_picture_pool.h
@@ -132,20 +132,6 @@ VLC_API picture_t * picture_pool_Get( picture_pool_t * ) VLC_USED;
 VLC_API picture_t *picture_pool_Wait(picture_pool_t *) VLC_USED;
 
 /**
- * Enumerates all pictures in a pool, both free and allocated.
- *
- * @param cb callback to invoke once for each picture
- * @param data opaque data parameter for the callback (first argument)
- *
- * @note Allocated pictures may be accessed asynchronously by other threads.
- * Therefore, only read-only picture parameters can be read by the callback,
- * typically picture_t.p_sys.
- * Provided those rules are respected, the function is thread-safe.
- */
-VLC_API void picture_pool_Enum( picture_pool_t *,
-                                void (*cb)(void *, picture_t *), void *data );
-
-/**
  * Cancel the picture pool.
  *
  * It won't return any pictures via picture_pool_Get or picture_pool_Wait if
diff --git a/src/libvlccore.sym b/src/libvlccore.sym
index db68d712c9..a71433b0ae 100644
--- a/src/libvlccore.sym
+++ b/src/libvlccore.sym
@@ -315,7 +315,6 @@ picture_NewFromResource
 picture_pool_Release
 picture_pool_Get
 picture_pool_GetSize
-picture_pool_Enum
 picture_pool_New
 picture_pool_NewExtended
 picture_pool_NewFromFormat
diff --git a/src/misc/picture_pool.c b/src/misc/picture_pool.c
index 9c896f840a..948c67bba5 100644
--- a/src/misc/picture_pool.c
+++ b/src/misc/picture_pool.c
@@ -305,12 +305,3 @@ unsigned picture_pool_GetSize(const picture_pool_t *pool)
 {
     return pool->picture_count;
 }
-
-void picture_pool_Enum(picture_pool_t *pool, void (*cb)(void *, picture_t *),
-                       void *opaque)
-{
-    /* NOTE: So far, the pictures table cannot change after the pool is created
-     * so there is no need to lock the pool mutex here. */
-    for (unsigned i = 0; i < pool->picture_count; i++)
-        cb(opaque, pool->picture[i]);
-}