[vlc-commits] macosx: Remove shadow from main window title in black mode

David Fuhrmann git at videolan.org
Sun Dec 16 20:17:53 CET 2018


vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sun Dec 16 18:23:09 2018 +0100| [3bfba86224b47ff750fda2ad6bcf0c3ee5684bce] | committer: David Fuhrmann

macosx: Remove shadow from main window title in black mode

Text without shadow looks far better.

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=3bfba86224b47ff750fda2ad6bcf0c3ee5684bce
---

 modules/gui/macosx/VLCMainWindowTitleView.m | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/modules/gui/macosx/VLCMainWindowTitleView.m b/modules/gui/macosx/VLCMainWindowTitleView.m
index 73e2bb960a..817a131fae 100644
--- a/modules/gui/macosx/VLCMainWindowTitleView.m
+++ b/modules/gui/macosx/VLCMainWindowTitleView.m
@@ -56,7 +56,6 @@
     NSImage * _oldFullscreenHoverImage;
     NSImage * _oldFullscreenOnClickImage;
 
-    NSShadow * _windowTitleShadow;
     NSDictionary * _windowTitleAttributesDictionary;
 
     BOOL b_nativeFullscreenMode;
@@ -237,17 +236,9 @@
 
 - (void)setWindowTitle:(NSString *)title
 {
-    if (!_windowTitleShadow) {
-        _windowTitleShadow = [[NSShadow alloc] init];
-        [_windowTitleShadow setShadowColor:[NSColor colorWithCalibratedWhite:1.0 alpha:0.5]];
-        [_windowTitleShadow setShadowOffset:NSMakeSize(0.0, -1.5)];
-        [_windowTitleShadow setShadowBlurRadius:0.5];
-    }
-
     NSMutableAttributedString *attributedTitleString = [[NSMutableAttributedString alloc] initWithString:title attributes: _windowTitleAttributesDictionary];
     NSUInteger i_titleLength = [title length];
 
-    [attributedTitleString addAttribute:NSShadowAttributeName value:_windowTitleShadow range:NSMakeRange(0, i_titleLength)];
     [attributedTitleString setAlignment: NSCenterTextAlignment range:NSMakeRange(0, i_titleLength)];
     [_titleLabel setAttributedStringValue:attributedTitleString];
 }



More information about the vlc-commits mailing list