[vlc-commits] xcb/render: X11 RENDER display plugin
Rémi Denis-Courmont
git at videolan.org
Wed Dec 19 20:11:40 CET 2018
vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Dec 12 23:15:08 2018 +0200| [19c8c3a7e696cc00d1d3dee642600344435c883d] | committer: Rémi Denis-Courmont
xcb/render: X11 RENDER display plugin
This brings the modern (well, at least current) X11 rendering protocol
for video output (refs #12348).
Compared to plain X11, it can handle scaling and orientation.
Compared to XVideo, it can handle orientation, and can crop correctly
(without bleeding), but it expects packed RGB rather than YCbCr.
Also RENDER would be able to handle SPU blending (and SPU scaling),
though this is left for future work, which neither X11 nor XVideo can.
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=19c8c3a7e696cc00d1d3dee642600344435c883d
---
NEWS | 1 +
configure.ac | 2 +
modules/MODULES_LIST | 1 +
modules/video_output/Makefile.am | 10 +-
modules/video_output/xcb/render.c | 541 ++++++++++++++++++++++++++++++++++++++
po/POTFILES.in | 1 +
6 files changed, 555 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index ef49706065..bb5cb78bdd 100644
--- a/NEWS
+++ b/NEWS
@@ -37,6 +37,7 @@ Access output:
* Added support for the RIST (Reliable Internet Stream Transport) Protocol
Video output:
+ * Added X11 RENDER video output plugin
* Remove aa plugin
* Remove evas plugin
* Remove omxil_vout plugin
diff --git a/configure.ac b/configure.ac
index 9b42a0b07d..19dd4c3568 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3125,6 +3125,8 @@ AS_IF([test "${enable_xcb}" != "no"], [
xcb_err="$xcb_err ${XCB_COMPOSITE_PKG_ERRORS}."])
PKG_CHECK_MODULES([XCB_RANDR], [xcb-randr >= 1.3],, [
xcb_err="$xcb_err ${XCB_RANDR_PKG_ERRORS}."])
+ PKG_CHECK_MODULES([XCB_RENDER], [xcb-render],, [
+ xcb_err="$xcb_err ${XCB_RENDER_PKG_ERRORS}."])
PKG_CHECK_MODULES([XCB_SHM], [xcb-shm >= 1.9.2],, [
xcb_err="$xcb_err ${XCB_SHM_PKG_ERRORS}."])
PKG_CHECK_MODULES([XCB_XKB], [xcb-xkb],, [
diff --git a/modules/MODULES_LIST b/modules/MODULES_LIST
index c5104b2234..440fb2ab25 100644
--- a/modules/MODULES_LIST
+++ b/modules/MODULES_LIST
@@ -479,6 +479,7 @@ $Id$
* xa: XA demuxer
* xcb_apps: List the application windows using XCB
* xcb_hotkeys: module to catch hotkeys when application doesn't have the focus
+ * xcb_render: RENDER video output using XCB
* xcb_screen: input module that takes screenshots of the primary monitor
* xcb_window: XCB window provider
* xcb_x11: a X11 video output using XCB
diff --git a/modules/video_output/Makefile.am b/modules/video_output/Makefile.am
index 6a5a6e8602..c55c187444 100644
--- a/modules/video_output/Makefile.am
+++ b/modules/video_output/Makefile.am
@@ -191,6 +191,14 @@ libxcb_x11_plugin_la_CFLAGS = $(AM_CFLAGS) \
libxcb_x11_plugin_la_LIBADD = libvlc_xcb_events.la \
$(XCB_LIBS) $(XCB_SHM_LIBS)
+libxcb_render_plugin_la_SOURCES = \
+ video_output/xcb/pictures.c video_output/xcb/pictures.h \
+ video_output/xcb/render.c
+libxcb_render_plugin_la_CFLAGS = $(AM_CFLAGS) \
+ $(XCB_CFLAGS) $(XCB_SHM_CFLAGS) $(XCB_RENDER_CFLAGS)
+libxcb_render_plugin_la_LIBADD = libvlc_xcb_events.la \
+ $(XCB_LIBS) $(XCB_SHM_LIBS) $(XCB_RENDER_LIBS)
+
libxcb_xv_plugin_la_SOURCES = \
video_output/xcb/pictures.c video_output/xcb/pictures.h \
video_output/xcb/xvideo.c
@@ -218,7 +226,7 @@ libglx_plugin_la_LIBADD = $(GL_LIBS) $(X_LIBS) $(X_PRE_LIBS) -lX11
if HAVE_XCB
pkglib_LTLIBRARIES += libvlc_xcb_events.la
-vout_LTLIBRARIES += libxcb_x11_plugin.la libxcb_window_plugin.la
+vout_LTLIBRARIES += libxcb_x11_plugin.la libxcb_render_plugin.la libxcb_window_plugin.la
if HAVE_XKBCOMMON_X11
libxcb_window_plugin_la_SOURCES += \
video_output/xcb/keysym.h video_output/xcb/xcb_keysym.h \
diff --git a/modules/video_output/xcb/render.c b/modules/video_output/xcb/render.c
new file mode 100644
index 0000000000..75b41bfd16
--- /dev/null
+++ b/modules/video_output/xcb/render.c
@@ -0,0 +1,541 @@
+/**
+ * @file render.c
+ * @brief X C Bindings video output module for VLC media player
+ */
+/*****************************************************************************
+ * Copyright © 2009-2018 Rémi Denis-Courmont
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; either version 2.1 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ *****************************************************************************/
+
+#ifdef HAVE_CONFIG_H
+# include <config.h>
+#endif
+
+#include <stdlib.h>
+#include <limits.h>
+#include <assert.h>
+
+#include <xcb/xcb.h>
+#include <xcb/render.h>
+
+#include <vlc_common.h>
+#include <vlc_plugin.h>
+#include <vlc_vout_display.h>
+
+#include "pictures.h"
+#include "events.h"
+
+struct vout_display_sys_t {
+ xcb_connection_t *conn;
+
+ struct {
+ xcb_pixmap_t source;
+ xcb_pixmap_t crop;
+ xcb_pixmap_t scale;
+ xcb_window_t dest;
+ } drawable;
+ struct {
+ xcb_render_picture_t source;
+ xcb_render_picture_t crop;
+ xcb_render_picture_t scale;
+ xcb_render_picture_t dest;
+ } picture;
+
+ xcb_gcontext_t gc;
+ xcb_window_t root;
+ xcb_render_pictformat_t fmt_id;
+
+ vout_display_place_t place;
+ int32_t src_x;
+ int32_t src_y;
+};
+
+static void Prepare(vout_display_t *vd, picture_t *pic, subpicture_t *subpic,
+ vlc_tick_t date)
+{
+ const video_format_t *fmt = &vd->source;
+ vout_display_sys_t *sys = vd->sys;
+ xcb_connection_t *conn = sys->conn;
+
+ xcb_put_image(conn, XCB_IMAGE_FORMAT_Z_PIXMAP, sys->drawable.source,
+ sys->gc, pic->p->i_pitch / pic->p->i_pixel_pitch,
+ pic->p->i_lines, 0, 0, 0, 32,
+ pic->p->i_pitch * pic->p->i_lines, pic->p->p_pixels);
+ /* Crop the picture with pixel accuracy */
+ xcb_render_composite(conn, XCB_RENDER_PICT_OP_SRC,
+ sys->picture.source, XCB_RENDER_PICTURE_NONE,
+ sys->picture.crop,
+ fmt->i_x_offset, fmt->i_y_offset, 0, 0,
+ 0, 0, fmt->i_visible_width, fmt->i_visible_height);
+
+ /* Blank background */
+ static const xcb_render_color_t black_color = { 0, 0, 0, 0 };
+ xcb_rectangle_t rects[] = {
+ { 0, 0, vd->cfg->display.width, vd->cfg->display.height },
+ };
+
+ xcb_render_fill_rectangles(conn, XCB_RENDER_PICT_OP_SRC,
+ sys->picture.scale, black_color,
+ ARRAY_SIZE(rects), rects);
+
+ /* Scale and orient the picture */
+ xcb_render_composite(conn, XCB_RENDER_PICT_OP_SRC,
+ sys->picture.crop, XCB_RENDER_PICTURE_NONE,
+ sys->picture.scale, sys->src_x, sys->src_y, 0, 0,
+ sys->place.x, sys->place.y,
+ sys->place.width, sys->place.height);
+
+ (void) subpic; (void) date;
+}
+
+static void Display(vout_display_t *vd, picture_t *pic)
+{
+ vout_display_sys_t *sys = vd->sys;
+ xcb_connection_t *conn = sys->conn;
+ xcb_void_cookie_t ck;
+ bool visible_dummy;
+
+ vlc_xcb_Manage(vd, conn, &visible_dummy);
+
+ /* Copy the scaled picture into the target picture, in other words
+ * copy the rendered pixmap into the window.
+ */
+ ck = xcb_render_composite_checked(conn, XCB_RENDER_PICT_OP_SRC,
+ sys->picture.scale,
+ XCB_RENDER_PICTURE_NONE,
+ sys->picture.dest, 0, 0, 0, 0, 0, 0,
+ vd->cfg->display.width,
+ vd->cfg->display.height);
+
+ xcb_generic_error_t *e = xcb_request_check(conn, ck);
+ if (e != NULL) { /* Not all errors will be detected here. */
+ msg_Dbg(vd, "%s: RENDER error %d", "cannot composite",
+ e->error_code);
+ free(e);
+ }
+ (void) pic;
+}
+
+static void CreateBuffers(vout_display_t *vd, const vout_display_cfg_t *cfg)
+{
+ const video_format_t *fmt = &vd->source;
+ vout_display_sys_t *sys = vd->sys;
+ xcb_connection_t *conn = sys->conn;
+
+ xcb_create_pixmap(conn, 32, sys->drawable.crop, sys->root,
+ fmt->i_visible_width, fmt->i_visible_height);
+ xcb_create_pixmap(conn, 32, sys->drawable.scale, sys->root,
+ cfg->display.width, cfg->display.height);
+ xcb_render_create_picture(conn, sys->picture.crop, sys->drawable.crop,
+ sys->fmt_id, 0, NULL);
+ xcb_render_create_picture(conn, sys->picture.scale,
+ sys->drawable.scale, sys->fmt_id, 0, NULL);
+
+ vout_display_place_t *place = &sys->place;
+ vout_display_PlacePicture(place, fmt, cfg);
+
+ /* Homogeneous coordinates transform from destination(place)
+ * to source(fmt) */
+ int32_t ax = place->height; /* multiply x instead of dividing y */
+ int32_t ay = place->width; /* multiply y instead of dividing x */
+ int32_t bx = 0;
+ int32_t by = 0;
+
+ switch (fmt->orientation) {
+ case ORIENT_TOP_LEFT:
+ case ORIENT_LEFT_TOP:
+ break;
+ case ORIENT_TOP_RIGHT:
+ case ORIENT_LEFT_BOTTOM:
+ ax *= -1;
+ bx -= place->width;
+ break;
+ case ORIENT_BOTTOM_LEFT:
+ case ORIENT_RIGHT_TOP:
+ ay *= -1;
+ by -= place->height;
+ break;
+ case ORIENT_BOTTOM_RIGHT:
+ case ORIENT_RIGHT_BOTTOM:
+ ax *= -1;
+ ay *= -1;
+ bx -= place->width;
+ by -= place->height;
+ break;
+ }
+
+ sys->src_x = bx;
+ sys->src_y = by;
+
+ xcb_render_transform_t transform = {
+ 0, 0, 0,
+ 0, 0, 0,
+ /* Multiply z by width and height to compensate for x and y above */
+ 0, 0, place->width * place->height,
+ };
+
+ if (ORIENT_IS_SWAP(fmt->orientation)) {
+ transform.matrix12 = ay * fmt->i_visible_width;
+ transform.matrix21 = ax * fmt->i_visible_height;
+ } else {
+ transform.matrix11 = ax * fmt->i_visible_width;
+ transform.matrix22 = ay * fmt->i_visible_height;
+ }
+
+ xcb_render_set_picture_transform(conn, sys->picture.crop, transform);
+}
+
+static void DeleteBuffers(vout_display_t *vd)
+{
+ vout_display_sys_t *sys = vd->sys;
+ xcb_connection_t *conn = sys->conn;
+
+ xcb_render_free_picture(conn, sys->picture.scale);
+ xcb_render_free_picture(conn, sys->picture.crop);
+ xcb_free_pixmap(conn, sys->drawable.scale);
+ xcb_free_pixmap(conn, sys->drawable.crop);
+}
+
+static int Control(vout_display_t *vd, int query, va_list ap)
+{
+ vout_display_sys_t *sys = vd->sys;
+
+ switch (query) {
+ case VOUT_DISPLAY_CHANGE_DISPLAY_SIZE:
+ case VOUT_DISPLAY_CHANGE_DISPLAY_FILLED:
+ case VOUT_DISPLAY_CHANGE_ZOOM:
+ case VOUT_DISPLAY_CHANGE_SOURCE_ASPECT:
+ case VOUT_DISPLAY_CHANGE_SOURCE_CROP: {
+ const vout_display_cfg_t *cfg = va_arg(ap,
+ const vout_display_cfg_t *);
+
+ /* Update the window size */
+ uint32_t mask = XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT;
+ const uint32_t values[] = {
+ cfg->display.width, cfg->display.height
+ };
+
+ xcb_configure_window(sys->conn, sys->drawable.dest, mask, values);
+ DeleteBuffers(vd);
+ CreateBuffers(vd, cfg);
+ xcb_flush(sys->conn);
+ return VLC_SUCCESS;
+ }
+
+ case VOUT_DISPLAY_RESET_PICTURES:
+ vlc_assert_unreachable();
+ default:
+ msg_Err(vd, "Unknown request in XCB RENDER display");
+ return VLC_EGENERIC;
+ }
+}
+
+/**
+ * Check that the X server supports the RENDER extension.
+ */
+static bool CheckRender(vout_display_t *vd, xcb_connection_t *conn)
+{
+ xcb_render_query_version_reply_t *r;
+ xcb_render_query_version_cookie_t ck;
+ bool ok = false;
+
+ ck = xcb_render_query_version(conn, 0, 11);
+ r = xcb_render_query_version_reply(conn, ck, NULL);
+
+ if (r == NULL)
+ msg_Err(vd, "RENDER extension not available");
+ else if (r->major_version > 0)
+ msg_Dbg(vd, "RENDER extension v%"PRIu32".%"PRIu32" unknown",
+ r->major_version, r->minor_version);
+ else if (r->major_version == 0 && r->minor_version < 6)
+ msg_Dbg(vd, "RENDER extension v%"PRIu32".%"PRIu32" too old",
+ r->major_version, r->minor_version);
+ else {
+ msg_Dbg(vd, "using RENDER extension v%"PRIu32".%"PRIu32,
+ r->major_version, r->minor_version);
+ ok = true;
+ }
+ free(r);
+ return ok;
+}
+
+static void Close(vout_display_t *vd)
+{
+ vout_display_sys_t *sys = vd->sys;
+
+ xcb_disconnect(sys->conn);
+}
+
+/* Convert RENDER picture format to VLC video chroma */
+static vlc_fourcc_t ParseFormat(const xcb_setup_t *setup,
+ const xcb_render_pictforminfo_t *pfi)
+{
+ if (pfi->type != XCB_RENDER_PICT_TYPE_DIRECT)
+ return 0;
+
+ const xcb_format_t *pixfmt = vlc_xcb_DepthToPixmapFormat(setup,
+ pfi->depth);
+ if (unlikely(pixfmt == NULL))
+ return 0;
+
+ const uint_fast8_t bpp = pixfmt->bits_per_pixel;
+ const xcb_render_directformat_t *d = &pfi->direct;
+
+ switch (pfi->depth) {
+ case 32:
+ if (bpp == 32 && d->red_mask == 0xff && d->green_mask == 0xff
+ && d->blue_mask == 0xff && d->alpha_mask == 0xff) {
+#ifdef WORDS_BIGENDIAN
+ if (d->red_shift == 24 && d->green_shift == 16
+ && d->blue_shift == 8)
+ return VLC_CODEC_RGBA;
+ if (d->red_shift == 8 && d->green_shift == 16
+ && d->blue_shift == 24)
+ return VLC_CODEC_BGRA;
+ if (d->red_shift == 16 && d->green_shift == 8
+ && d->blue_shift == 0)
+ return VLC_CODEC_ARGB;
+#else
+ if (d->red_shift == 0 && d->green_shift == 8
+ && d->blue_shift == 16)
+ return VLC_CODEC_RGBA;
+ if (d->red_shift == 16 && d->green_shift == 8
+ && d->blue_shift == 0)
+ return VLC_CODEC_BGRA;
+ if (d->red_shift == 8 && d->green_shift == 16
+ && d->blue_shift == 24)
+ return VLC_CODEC_ARGB;
+#endif
+ }
+ break;
+ /* TODO 30 bits HDR */
+ case 24:
+ if (bpp == 32 && d->red_mask == 0xff && d->green_mask == 0xff
+ && d->blue_mask == 0xff && d->alpha_mask == 0x00)
+ return VLC_CODEC_RGB32;
+ if (bpp == 32 && d->red_mask == 0xff && d->green_mask == 0xff
+ && d->blue_mask == 0xff && d->alpha_mask == 0x00)
+ return VLC_CODEC_RGB24;
+ break;
+ case 16:
+ if (bpp == 16 && d->red_mask == 0x1f && d->green_mask == 0x3f
+ && d->blue_mask == 0x1f && d->alpha_mask == 0x00)
+ return VLC_CODEC_RGB16;
+ break;
+ case 15:
+ if (bpp == 16 && d->red_mask == 0x1f && d->green_mask == 0x1f
+ && d->blue_mask == 0x1f && d->alpha_mask == 0x00)
+ return VLC_CODEC_RGB15;
+ break;
+ }
+
+ return 0;
+}
+
+/* Find the RENDER screen for the X11 screen */
+static const xcb_render_pictscreen_t *
+FindPictScreen(const xcb_setup_t *setup, const xcb_screen_t *scr,
+ const xcb_render_query_pict_formats_reply_t *r)
+{
+ xcb_screen_iterator_t si = xcb_setup_roots_iterator(setup);
+ unsigned n = 0;
+
+ while (si.data != scr) {
+ assert(si.rem > 0);
+ n++;
+ xcb_screen_next(&si);
+ }
+
+ xcb_render_pictscreen_iterator_t rsi =
+ xcb_render_query_pict_formats_screens_iterator(r);
+
+ while (n > 0) {
+ if (unlikely(rsi.rem == 0))
+ return NULL; /* buggy server */
+
+ n--;
+ xcb_render_pictscreen_next(&rsi);
+ }
+ return rsi.data;
+}
+
+/* Find an X11 visual for a RENDER picture format */
+static xcb_visualid_t
+FindVisual(const xcb_setup_t *setup, const xcb_screen_t *scr,
+ const xcb_render_query_pict_formats_reply_t *r,
+ xcb_render_pictformat_t fmt_id)
+{
+ const xcb_render_pictscreen_t *rs = FindPictScreen(setup, scr, r);
+ if (rs == NULL)
+ return 0;
+
+ xcb_render_pictdepth_iterator_t rdi =
+ xcb_render_pictscreen_depths_iterator(rs);
+
+ while (rdi.rem > 0) {
+ const xcb_render_pictdepth_t *rd = rdi.data;
+ xcb_render_pictvisual_iterator_t rvi =
+ xcb_render_pictdepth_visuals_iterator(rd);
+
+ while (rvi.rem > 0) {
+ const xcb_render_pictvisual_t *pv = rvi.data;
+
+ if (pv->format == fmt_id)
+ return pv->visual;
+
+ xcb_render_pictvisual_next(&rvi);
+ }
+ xcb_render_pictdepth_next(&rdi);
+ }
+ return 0;
+}
+
+/**
+ * Probe the X server.
+ */
+static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
+ video_format_t *fmtp, vlc_video_context *ctx)
+{
+ vlc_object_t *obj = VLC_OBJECT(vd);
+
+ vout_display_sys_t *sys = vlc_obj_malloc(obj, sizeof (*sys));
+ if (unlikely(sys == NULL))
+ return VLC_ENOMEM;
+
+ vd->sys = sys;
+
+ /* Connect to X */
+ xcb_connection_t *conn;
+ const xcb_screen_t *screen;
+
+ if (vlc_xcb_parent_Create(vd, cfg, &conn, &screen) == NULL)
+ return VLC_EGENERIC;
+
+ sys->conn = conn;
+ sys->root = screen->root;
+ sys->fmt_id = 0;
+
+ if (!CheckRender(vd, conn))
+ goto error;
+
+ xcb_render_query_pict_formats_cookie_t pic_fmt_ck =
+ xcb_render_query_pict_formats(conn);
+ xcb_render_query_pict_formats_reply_t *pic_fmt_r =
+ xcb_render_query_pict_formats_reply(conn, pic_fmt_ck, NULL);
+ if (pic_fmt_r == NULL)
+ goto error;
+
+ const xcb_setup_t *setup = xcb_get_setup(conn);
+ const xcb_render_pictforminfo_t *const pic_fmts =
+ xcb_render_query_pict_formats_formats(pic_fmt_r);
+ xcb_visualid_t vid = 0;
+
+ for (unsigned i = 0; i < pic_fmt_r->num_formats; i++) {
+ const xcb_render_pictforminfo_t *const pic_fmt = pic_fmts + i;
+ const xcb_render_directformat_t *const d = &pic_fmt->direct;
+
+ vid = FindVisual(setup, screen, pic_fmt_r, pic_fmt->id);
+ if (vid == 0)
+ continue;
+
+ /* Use only ARGB for now. 32-bits is guaranteed to work. */
+ if (pic_fmt->depth != 32)
+ continue;
+
+ fmtp->i_chroma = ParseFormat(setup, pic_fmt);
+ if (fmtp->i_chroma == 0)
+ continue;
+
+ fmtp->i_rmask = ((uint32_t)d->red_mask) << d->red_shift;
+ fmtp->i_gmask = ((uint32_t)d->green_mask) << d->green_shift;
+ fmtp->i_bmask = ((uint32_t)d->blue_mask) << d->blue_shift;
+ sys->fmt_id = pic_fmt->id;
+ break;
+ }
+
+ free(pic_fmt_r);
+
+ if (sys->fmt_id == 0)
+ goto error;
+
+ msg_Dbg(obj, "using RENDER picture format %u", sys->fmt_id);
+ msg_Dbg(obj, "using X11 visual 0x%"PRIx32, vid);
+
+ sys->drawable.source = xcb_generate_id(conn);
+ sys->drawable.crop = xcb_generate_id(conn);
+ sys->drawable.scale = xcb_generate_id(conn);
+ sys->drawable.dest = xcb_generate_id(conn);
+ sys->picture.source = xcb_generate_id(conn);
+ sys->picture.crop = xcb_generate_id(conn);
+ sys->picture.scale = xcb_generate_id(conn);
+ sys->picture.dest = xcb_generate_id(conn);
+ sys->gc = xcb_generate_id(conn);
+
+ xcb_colormap_t cmap = xcb_generate_id(conn);
+ uint32_t cw_mask =
+ XCB_CW_BACK_PIXEL |
+ XCB_CW_BORDER_PIXEL |
+ XCB_CW_EVENT_MASK |
+ XCB_CW_COLORMAP;
+ const uint32_t cw_list[] = {
+ /* XCB_CW_BACK_PIXEL */
+ screen->black_pixel,
+ /* XCB_CW_BORDER_PIXEL */
+ screen->black_pixel,
+ /* XCB_CW_EVENT_MASK */
+ 0,
+ /* XCB_CW_COLORMAP */
+ cmap,
+ };
+
+ xcb_create_colormap(conn, XCB_COLORMAP_ALLOC_NONE, cmap, screen->root,
+ vid);
+ xcb_create_pixmap(conn, 32, sys->drawable.source, screen->root,
+ vd->source.i_width, vd->source.i_height);
+ xcb_create_gc(conn, sys->gc, sys->drawable.source, 0, NULL);
+ xcb_create_window(conn, 32, sys->drawable.dest, cfg->window->handle.xid,
+ 0, 0, cfg->display.width, cfg->display.height, 0,
+ XCB_WINDOW_CLASS_INPUT_OUTPUT, vid, cw_mask, cw_list);
+ xcb_render_create_picture(conn, sys->picture.source, sys->drawable.source,
+ sys->fmt_id, 0, NULL);
+ xcb_render_create_picture(conn, sys->picture.dest, sys->drawable.dest,
+ sys->fmt_id, 0, NULL);
+ CreateBuffers(vd, cfg);
+ xcb_map_window(conn, sys->drawable.dest);
+
+ vd->prepare = Prepare;
+ vd->display = Display;
+ vd->control = Control;
+
+ (void) ctx;
+ return VLC_SUCCESS;
+
+error:
+ xcb_disconnect(conn);
+ return VLC_EGENERIC;
+}
+
+/* TODO: configurable filter */
+
+vlc_module_begin()
+ set_shortname(N_("RENDER"))
+ set_description(N_("X11 RENDER video output (XCB)"))
+ set_category(CAT_VIDEO)
+ set_subcategory(SUBCAT_VIDEO_VOUT)
+ set_capability("vout display", 200)
+ set_callbacks(Open, Close)
+ add_shortcut("x11-render", "xcb-render", "render")
+vlc_module_end()
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 507aeff5af..85c3e001e1 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1184,6 +1184,7 @@ modules/video_output/vdummy.c
modules/video_output/vmem.c
modules/video_output/wayland/shm.c
modules/video_output/wayland/xdg-shell.c
+modules/video_output/xcb/render.c
modules/video_output/xcb/window.c
modules/video_output/xcb/x11.c
modules/video_output/xcb/xvideo.c
More information about the vlc-commits
mailing list