[vlc-commits] macosx: Workaround graphical issues with fullscreen panel buttons

[David Fuhrmann]

vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Thu Dec 20 10:09:20 2018 +0100| [cb0b0fc8d2c31704301afce87e8bd98c6474a07a] | committer: David Fuhrmann

macosx: Workaround graphical issues with fullscreen panel buttons

On macOS Mojave only, those buttons are wrongly rendered (they look
as they are disabled). If you touch those buttons, they look fine
again.
This is a quick workaround to fix the graphical appearance, but
the underlying issue is not clear yet.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=cb0b0fc8d2c31704301afce87e8bd98c6474a07a
---

 modules/gui/macosx/VLCFSPanelController.m | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/modules/gui/macosx/VLCFSPanelController.m b/modules/gui/macosx/VLCFSPanelController.m
index 4b9f43400b..8f30691cdf 100644
--- a/modules/gui/macosx/VLCFSPanelController.m
+++ b/modules/gui/macosx/VLCFSPanelController.m
@@ -284,6 +284,17 @@ static NSString *kAssociatedFullscreenRect = @"VLCFullscreenAssociatedWindowRect
 
 - (void)setSeekable:(BOOL)seekable
 {
+    // Workaround graphical issues in Mojave.
+    // TODO: This needs a proper fix
+    [_forwardButton setEnabled:NO];
+    [_backwardButton setEnabled:NO];
+    [_nextButton setEnabled:NO];
+    [_nextButton setEnabled:YES];
+    [_previousButton setEnabled:NO];
+    [_previousButton setEnabled:YES];
+    [_fullscreenButton setEnabled:NO];
+    [_fullscreenButton setEnabled:YES];
+
     [_timeSlider setEnabled:seekable];
     [_forwardButton setEnabled:seekable];
     [_backwardButton setEnabled:seekable];