[vlc-commits] qt: dialogs: Use the correct type for progress context

Hugo Beauzée-Luyssen git at videolan.org
Fri Feb 9 13:44:57 CET 2018


vlc/vlc-3.0 | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Fri Feb  9 13:42:46 2018 +0100| [b18c5c79b84674b754bab5dc1fccf9243c178115] | committer: Hugo Beauzée-Luyssen

qt: dialogs: Use the correct type for progress context

This seems to fix #18640 and #17060

(cherry picked from commit 90dde5edfbaee89e16386a42bc5626845383e89f)
Signed-off-by: Hugo Beauzée-Luyssen <hugo at beauzee.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=b18c5c79b84674b754bab5dc1fccf9243c178115
---

 modules/gui/qt/dialogs/external.cpp | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/modules/gui/qt/dialogs/external.cpp b/modules/gui/qt/dialogs/external.cpp
index 665a92f768..58444e1cce 100644
--- a/modules/gui/qt/dialogs/external.cpp
+++ b/modules/gui/qt/dialogs/external.cpp
@@ -167,14 +167,11 @@ void DialogHandler::cancel(vlc_dialog_id *p_id)
 void DialogHandler::updateProgress(vlc_dialog_id *p_id, float f_value,
                                    const QString &text)
 {
-    DialogWrapper *p_wrapper =
-        static_cast<DialogWrapper *>(vlc_dialog_id_get_context(p_id));
+    ProgressDialogWrapper *p_wrapper =
+        static_cast<ProgressDialogWrapper *>(vlc_dialog_id_get_context(p_id));
 
-    ProgressDialogWrapper *p_progress_wrapper
-        = dynamic_cast<ProgressDialogWrapper *>(p_wrapper);
-
-    if (p_progress_wrapper != NULL)
-        p_progress_wrapper->updateProgress(f_value, text);
+    if (p_wrapper != NULL)
+        p_wrapper->updateProgress(f_value, text);
 }
 
 void DialogHandler::displayError(const QString &title, const QString &text)



More information about the vlc-commits mailing list