[vlc-commits] chromecast: fix use-after-free

[Thomas Guillem]

vlc/vlc-3.0 | branch: master | Thomas Guillem <thomas at gllm.fr> | Tue Feb 20 17:41:11 2018 +0100| [10618de821f69d2cffd1840b61632339038e1dd1] | committer: Thomas Guillem

chromecast: fix use-after-free

Since the url can use the fifo from its callbacks.

(cherry picked from commit d9815d1956fe24ff984f7a13e46e70b45a1e22fc)
Signed-off-by: Thomas Guillem <thomas at gllm.fr>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=10618de821f69d2cffd1840b61632339038e1dd1
---

 modules/stream_out/chromecast/cast.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/stream_out/chromecast/cast.cpp b/modules/stream_out/chromecast/cast.cpp
index ee6f7cb578..f18bd4eef7 100644
--- a/modules/stream_out/chromecast/cast.cpp
+++ b/modules/stream_out/chromecast/cast.cpp
@@ -353,8 +353,8 @@ sout_access_out_sys_t::sout_access_out_sys_t(httpd_host_t *httpd_host,
 
 sout_access_out_sys_t::~sout_access_out_sys_t()
 {
-    block_FifoRelease(m_fifo);
     httpd_UrlDelete(m_url);
+    block_FifoRelease(m_fifo);
 }
 
 void sout_access_out_sys_t::clearUnlocked()