[vlc-commits] macOS codesign.sh: Do not try to sign Breakpad if it is not present

David Fuhrmann git at videolan.org
Sat Jan 13 18:46:08 CET 2018


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sat Jan 13 18:41:13 2018 +0100| [96a9d2d3ddae7b4cf8b6f3a10bda7d717e814c82] | committer: David Fuhrmann

macOS codesign.sh: Do not try to sign Breakpad if it is not present

As this needs to be explicitly enabled in configure.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=96a9d2d3ddae7b4cf8b6f3a10bda7d717e814c82
---

 extras/package/macosx/codesign.sh | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/extras/package/macosx/codesign.sh b/extras/package/macosx/codesign.sh
index c85ad0c160..b4aa0eec99 100755
--- a/extras/package/macosx/codesign.sh
+++ b/extras/package/macosx/codesign.sh
@@ -117,8 +117,10 @@ sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupd
 sign "VLC.app/Contents/Frameworks/Sparkle.framework/Resources/Autoupdate.app" "org.sparkle-project.Sparkle.Autoupdate"
 sign "VLC.app/Contents/Frameworks/Sparkle.framework/Versions/A" "org.sparkle-project.Sparkle"
 
-sign "VLC.app/Contents/Frameworks/Breakpad.framework/Resources/crash_report_sender.app" "com.Breakpad.crash_report_sender"
-sign "VLC.app/Contents/Frameworks/Breakpad.framework/Versions/A" "com.googlecode.google-breakpad"
+if [ -e "VLC.app/Contents/Frameworks/Breakpad.framework" ]; then
+    sign "VLC.app/Contents/Frameworks/Breakpad.framework/Resources/crash_report_sender.app" "com.Breakpad.crash_report_sender"
+    sign "VLC.app/Contents/Frameworks/Breakpad.framework/Versions/A" "com.googlecode.google-breakpad"
+fi
 
 info "Signing the framework headers"
 for i in $(find VLC.app/Contents/Frameworks -type f -name "*.h" -exec echo {} \;)
@@ -184,7 +186,10 @@ sign "VLC.app" "org.videolan.vlc"
 info "all items signed, validating..."
 
 info "Validating frameworks"
-codesign --verify -vv VLC.app/Contents/Frameworks/Breakpad.framework
+if [ -e "VLC.app/Contents/Frameworks/Breakpad.framework" ]; then
+    codesign --verify -vv VLC.app/Contents/Frameworks/Breakpad.framework
+fi
+
 codesign --verify -vv VLC.app/Contents/Frameworks/Growl.framework
 codesign --verify -vv VLC.app/Contents/Frameworks/Sparkle.framework
 



More information about the vlc-commits mailing list