[vlc-commits] demux:mkv: don't delete our segment parser if tags are too big

[Steve Lhomme]

vlc/vlc-3.0 | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Thu Jan 25 13:21:15 2018 +0100| [90d365550a0412cef1b8f3fd93fbd81b99c3be55] | committer: Jean-Baptiste Kempf

demux:mkv: don't delete our segment parser if tags are too big

it will end up with a double free

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=90d365550a0412cef1b8f3fd93fbd81b99c3be55
---

 modules/demux/mkv/matroska_segment.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/demux/mkv/matroska_segment.cpp b/modules/demux/mkv/matroska_segment.cpp
index 53c72b77f2..b2c4d62f7f 100644
--- a/modules/demux/mkv/matroska_segment.cpp
+++ b/modules/demux/mkv/matroska_segment.cpp
@@ -282,7 +282,6 @@ bool matroska_segment_c::ParseSimpleTags( SimpleTag* pout_simple, KaxTagSimple *
             if( unlikely( !el->ValidateSize() ) )
             {
                 msg_Err( &sys.demuxer, "Error %s too big ignoring the tag", typeid(*el).name() );
-                delete ep;
                 return false;
             }
             if( MKV_CHECKED_PTR_DECL ( ktn_ptr, KaxTagName, el ) )