[vlc-commits] Remove old logger interface, deprecated for years

[Jean-Baptiste Kempf]

vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Jul 11 18:14:10 2018 +0200| [d3613a443f88e6232796d136c87ac39643fb5f90] | committer: Jean-Baptiste Kempf

Remove old logger interface, deprecated for years

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d3613a443f88e6232796d136c87ac39643fb5f90
---

 modules/MODULES_LIST     |  1 -
 modules/misc/Makefile.am |  3 +-
 modules/misc/logger.c    | 84 ------------------------------------------------
 po/POTFILES.in           |  1 -
 4 files changed, 1 insertion(+), 88 deletions(-)

diff --git a/modules/MODULES_LIST b/modules/MODULES_LIST
index 7b30085411..244a8f2eea 100644
--- a/modules/MODULES_LIST
+++ b/modules/MODULES_LIST
@@ -219,7 +219,6 @@ $Id$
  * linsys_sdi: Linsys SDI cards access module
  * lirc: Linux infrared control module
  * live555: rtp demux based on liveMedia (live555.com)
- * logger: file logger plugin
  * logo: video filter to put a logo on the video
  * lpcm: LPCM decoder
  * lua: Lua scripting inteface
diff --git a/modules/misc/Makefile.am b/modules/misc/Makefile.am
index 5806f62aa9..f2d13ed278 100644
--- a/modules/misc/Makefile.am
+++ b/modules/misc/Makefile.am
@@ -1,9 +1,8 @@
 miscdir = $(pluginsdir)/misc
 
-liblogger_plugin_la_SOURCES = misc/logger.c
 libstats_plugin_la_SOURCES = misc/stats.c
 
-misc_LTLIBRARIES = liblogger_plugin.la libstats_plugin.la
+misc_LTLIBRARIES = libstats_plugin.la
 
 libaudioscrobbler_plugin_la_SOURCES = misc/audioscrobbler.c
 libaudioscrobbler_plugin_la_LIBADD = $(SOCKET_LIBS)
diff --git a/modules/misc/logger.c b/modules/misc/logger.c
deleted file mode 100644
index 84822fdf3f..0000000000
--- a/modules/misc/logger.c
+++ /dev/null
@@ -1,84 +0,0 @@
-/*****************************************************************************
- * logger.c : file logging plugin for vlc
- *****************************************************************************
- * Copyright (C) 2002-2008 the VideoLAN team
- * $Id$
- *
- * Authors: Samuel Hocevar <sam at zoy.org>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
- *****************************************************************************/
-
-/*****************************************************************************
- * Preamble
- *****************************************************************************/
-
-#ifdef HAVE_CONFIG_H
-# include "config.h"
-#endif
-
-#define VLC_MODULE_LICENSE VLC_LICENSE_GPL_2_PLUS
-#include <vlc_common.h>
-#include <vlc_plugin.h>
-#include <vlc_interface.h>
-
-#include <stdarg.h>
-
-/*****************************************************************************
- * Local prototypes
- *****************************************************************************/
-static int  Open    ( vlc_object_t * );
-static void Close   ( vlc_object_t * );
-
-/*****************************************************************************
- * Module descriptor
- *****************************************************************************/
-vlc_module_begin ()
-    set_shortname( N_( "Logging" ) )
-    set_description( N_("File logging") )
-
-    set_category( CAT_ADVANCED )
-    set_subcategory( SUBCAT_ADVANCED_MISC )
-
-    add_obsolete_string( "rrd-file" )
-
-    set_capability( "interface", 0 )
-    set_callbacks( Open, Close )
-vlc_module_end ()
-
-/*****************************************************************************
- * Open: initialize and create stuff
- *****************************************************************************/
-static int Open( vlc_object_t *p_this )
-{
-    intf_thread_t *p_intf = (intf_thread_t *)p_this;
-
-    msg_Err( p_intf, "The logger interface no longer exists." );
-    msg_Info( p_intf, "As of VLC version 0.9.0, use --file-logging to write "
-              "logs to a file." );
-# ifndef _WIN32
-    msg_Info( p_intf, "Use --syslog to send logs to the system logger." );
-# endif
-    return VLC_EGENERIC;
-}
-
-/*****************************************************************************
- * Close: destroy interface stuff
- *****************************************************************************/
-static void Close( vlc_object_t *p_this )
-{
-    /* Flush the queue and unsubscribe from the message queue */
-    vlc_LogSet( p_this->obj.libvlc, NULL, NULL );
-}
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 4f83861574..96d2770a35 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -993,7 +993,6 @@ modules/misc/gnutls.c
 modules/misc/inhibit/dbus.c
 modules/misc/inhibit/wl-idle-inhibit.c
 modules/misc/inhibit/xdg.c
-modules/misc/logger.c
 modules/misc/playlist/export.c
 modules/misc/playlist/html.c
 modules/misc/playlist/m3u.c