[vlc-commits] macosx: remove write-only variables
Felix Paul Kühne
git at videolan.org
Sat Jun 9 17:44:09 CEST 2018
vlc | branch: master | Felix Paul Kühne <felix at feepk.net> | Sat Jun 9 16:14:33 2018 +0200| [1e03d06491e5da4278a2423d2ecd11932b002cff] | committer: Felix Paul Kühne
macosx: remove write-only variables
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1e03d06491e5da4278a2423d2ecd11932b002cff
---
modules/gui/macosx/VLCPlaylist.m | 1 -
modules/gui/macosx/VLCPlaylistInfo.m | 4 ++--
modules/gui/macosx/VLCStringUtility.m | 5 ++---
modules/gui/macosx/applescript.m | 2 --
4 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/modules/gui/macosx/VLCPlaylist.m b/modules/gui/macosx/VLCPlaylist.m
index b960fa9e1a..895faf8599 100644
--- a/modules/gui/macosx/VLCPlaylist.m
+++ b/modules/gui/macosx/VLCPlaylist.m
@@ -702,7 +702,6 @@
- (void)outlineView:(NSOutlineView *)outlineView didClickTableColumn:(NSTableColumn *)aTableColumn
{
int type = 0;
- intf_thread_t *p_intf = getIntf();
NSString * identifier = [aTableColumn identifier];
if (_sortTableColumn == aTableColumn)
diff --git a/modules/gui/macosx/VLCPlaylistInfo.m b/modules/gui/macosx/VLCPlaylistInfo.m
index 3fc2dd7461..c05cb1ee45 100644
--- a/modules/gui/macosx/VLCPlaylistInfo.m
+++ b/modules/gui/macosx/VLCPlaylistInfo.m
@@ -364,8 +364,8 @@ FREENULL( psz_##foo );
- (IBAction)downloadCoverArt:(id)sender
{
- playlist_t *p_playlist = pl_Get(getIntf());
- if (p_item) libvlc_ArtRequest(getIntf()->obj.libvlc, p_item, META_REQUEST_OPTION_NONE);
+ if (p_item)
+ libvlc_ArtRequest(getIntf()->obj.libvlc, p_item, META_REQUEST_OPTION_NONE);
}
@end
diff --git a/modules/gui/macosx/VLCStringUtility.m b/modules/gui/macosx/VLCStringUtility.m
index 56067fc522..7c3a383bf4 100644
--- a/modules/gui/macosx/VLCStringUtility.m
+++ b/modules/gui/macosx/VLCStringUtility.m
@@ -73,7 +73,6 @@ NSString *const kVLCMediaUnknown = @"Unknown";
NSMutableString *o_wrapped;
NSString *o_out_string;
NSRange glyphRange, effectiveRange, charRange;
- NSRect lineFragmentRect;
unsigned glyphIndex, breaksInserted = 0;
NSTextStorage *o_storage = [[NSTextStorage alloc] initWithString: o_in_string
@@ -91,8 +90,8 @@ NSString *const kVLCMediaUnknown = @"Unknown";
for (glyphIndex = glyphRange.location ; glyphIndex < NSMaxRange(glyphRange) ;
glyphIndex += effectiveRange.length) {
- lineFragmentRect = [o_layout_manager lineFragmentRectForGlyphAtIndex: glyphIndex
- effectiveRange: &effectiveRange];
+ [o_layout_manager lineFragmentRectForGlyphAtIndex: glyphIndex
+ effectiveRange: &effectiveRange];
charRange = [o_layout_manager characterRangeForGlyphRange: effectiveRange
actualGlyphRange: &effectiveRange];
if ([o_wrapped lineRangeForRange:
diff --git a/modules/gui/macosx/applescript.m b/modules/gui/macosx/applescript.m
index 04676e9c5b..9f6893b1ad 100644
--- a/modules/gui/macosx/applescript.m
+++ b/modules/gui/macosx/applescript.m
@@ -68,8 +68,6 @@
NSString *o_command = [[self commandDescription] commandName];
NSString *o_parameter = [self directParameter];
- intf_thread_t * p_intf = getIntf();
-
if ([o_command isEqualToString:@"play"])
[[VLCCoreInteraction sharedInstance] playOrPause];
else if ([o_command isEqualToString:@"stop"])
More information about the vlc-commits
mailing list