[vlc-commits] variables: remove useless VLC_VAR_GETMAX parameter

Rémi Denis-Courmont git at videolan.org
Sun Jun 10 12:10:54 CEST 2018


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Jun  9 13:07:17 2018 +0300| [8f6a9a7e0bd7f0e7a03d417cb0511c498d40efda] | committer: Rémi Denis-Courmont

variables: remove useless VLC_VAR_GETMAX parameter

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=8f6a9a7e0bd7f0e7a03d417cb0511c498d40efda
---

 modules/gui/qt/components/extended_panels.cpp |  3 +--
 test/src/misc/variables.c                     | 10 +++++-----
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/modules/gui/qt/components/extended_panels.cpp b/modules/gui/qt/components/extended_panels.cpp
index 39ee1ef085..f76282ea5c 100644
--- a/modules/gui/qt/components/extended_panels.cpp
+++ b/modules/gui/qt/components/extended_panels.cpp
@@ -721,8 +721,7 @@ void ExtV4l2::Refresh( void )
                         if( val2.i_int < INT_MIN )
                             val2.i_int = INT_MIN; /* FIXME */
                         slider->setMinimum( val2.i_int );
-                        var_Change( p_obj, psz_var, VLC_VAR_GETMAX,
-                                    &val2, NULL );
+                        var_Change( p_obj, psz_var, VLC_VAR_GETMAX, &val2 );
                         if( val2.i_int > INT_MAX )
                             val2.i_int = INT_MAX; /* FIXME */
                         slider->setMaximum( val2.i_int );
diff --git a/test/src/misc/variables.c b/test/src/misc/variables.c
index d97eeaf752..df1a5a345d 100644
--- a/test/src/misc/variables.c
+++ b/test/src/misc/variables.c
@@ -286,7 +286,7 @@ static void test_limits( libvlc_int_t *p_libvlc )
 
     var_Change( p_libvlc, "bla", VLC_VAR_GETMIN, &val );
     assert( val.i_int == INT64_MIN );
-    var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val, NULL );
+    var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val );
     assert( val.i_int == INT64_MAX );
 
     var_Change( p_libvlc, "bla", VLC_VAR_SETMINMAX,
@@ -295,7 +295,7 @@ static void test_limits( libvlc_int_t *p_libvlc )
 
     var_Change( p_libvlc, "bla", VLC_VAR_GETMIN, &val );
     assert( val.i_int == -1234 );
-    var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val, NULL );
+    var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val );
     assert( val.i_int == 12345 );
 
     var_SetInteger( p_libvlc, "bla", -123456 );
@@ -378,7 +378,7 @@ static void test_change( libvlc_int_t *p_libvlc )
     /* Test everything is right */
     var_Change( p_libvlc, "bla", VLC_VAR_GETMIN, &val );
     assert( val.i_int == min.i_int );
-    var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val, NULL );
+    var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val );
     assert( val.i_int == max.i_int );
     var_Change( p_libvlc, "bla", VLC_VAR_GETSTEP, &val, NULL );
     assert( val.i_int == step.i_int );
@@ -402,13 +402,13 @@ static void test_creation_and_type( libvlc_int_t *p_libvlc )
 
     assert( var_Change( p_libvlc, "bla", VLC_VAR_GETMIN, &val ) != 0
          || val.i_int == INT64_MIN );
-    assert( var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val, NULL ) != 0
+    assert( var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val ) != 0
          || val.i_int == INT64_MAX );
     val.i_int = 4212;
     var_Change( p_libvlc, "bla", VLC_VAR_SETMINMAX, &val, &val );
     assert( var_Change( p_libvlc, "bla", VLC_VAR_GETMIN, &val ) == 0
          && val.i_int == 4212 );
-    assert( var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val, NULL ) == 0
+    assert( var_Change( p_libvlc, "bla", VLC_VAR_GETMAX, &val ) == 0
          && val.i_int == 4212 );
 
     assert( var_Change( p_libvlc, "bla" , VLC_VAR_GETSTEP, &val, NULL ) != 0 );



More information about the vlc-commits mailing list