[vlc-commits] xdg-shell: postpone setting fullscreen

Rémi Denis-Courmont git at videolan.org
Mon Jun 18 20:05:56 CEST 2018


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Jun 18 20:51:28 2018 +0300| [dff1b4fbce3f56c4ffaf54ec8d3a976274763793] | committer: Rémi Denis-Courmont

xdg-shell: postpone setting fullscreen

...until after the event thread is started.
There are no points in making a special case here.

Note: Some window manager may not handle a window going fullscreen at
first correctly, failing to set the correct size.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=dff1b4fbce3f56c4ffaf54ec8d3a976274763793
---

 modules/video_output/wayland/xdg-shell.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/modules/video_output/wayland/xdg-shell.c b/modules/video_output/wayland/xdg-shell.c
index a631d78768..dd95fac9f7 100644
--- a/modules/video_output/wayland/xdg-shell.c
+++ b/modules/video_output/wayland/xdg-shell.c
@@ -559,15 +559,11 @@ static int Open(vout_window_t *wnd, const vout_window_cfg_t *cfg)
     wnd->display.wl = display;
     wnd->control = Control;
 
-    if (cfg->is_fullscreen)
-    {
-        vout_window_SetFullScreen(wnd, NULL);
-        sys->fullscreen = true;
-    }
-
     if (vlc_clone(&sys->thread, Thread, wnd, VLC_THREAD_PRIORITY_LOW))
         goto error;
 
+    if (cfg->is_fullscreen)
+        vout_window_SetFullScreen(wnd, NULL);
 #ifdef XDG_SHELL_UNSTABLE
     if (sys->unstable)
     {



More information about the vlc-commits mailing list