[vlc-commits] Revert "macosx: Spin event loop to process pending selectors on main thread"

[David Fuhrmann]

vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sun Mar 18 18:28:37 2018 +0100| [9ec38cd7ffb93a4c289fe210575897337cd0f231] | committer: Jean-Baptiste Kempf

Revert "macosx: Spin event loop to process pending selectors on main thread"

This caused too many unrelated crashes / problems.

This partly reverts commit 5d0d2b0d533df40c6e78460d2a320997e7e3ee34.

close #19983

(cherry picked from commit bbae6326df1dc79b9bbfde520767b0f3b10d7c56)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=9ec38cd7ffb93a4c289fe210575897337cd0f231
---

 modules/gui/macosx/VLCMain.m | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/modules/gui/macosx/VLCMain.m b/modules/gui/macosx/VLCMain.m
index 9f33cab3f0..65b5e4306f 100644
--- a/modules/gui/macosx/VLCMain.m
+++ b/modules/gui/macosx/VLCMain.m
@@ -114,16 +114,6 @@ void CloseIntf (vlc_object_t *p_this)
         [[VLCMain sharedInstance] applicationWillTerminate:nil];
         [VLCMain killInstance];
 
-        /*
-         * Spinning the event loop here is important to help cleaning up all objects which should be
-         * destroyed here. Its possible that main thread selectors (which hold a strong reference
-         * to the target object), are still in the queue (e.g. fired from variable callback).
-         * Thus make sure those are still dispatched and the references to the targets are
-         * cleared, to allow the objects to be released.
-         */
-        msg_Dbg(p_this, "Spin the event loop to clean up the interface");
-        [[NSRunLoop mainRunLoop] runUntilDate:[NSDate date]];
-
         p_interface_thread = nil;
     }
 }