[vlc-commits] macOS buil.sh: Workaround for breakpad symbol generation

[David Fuhrmann]

vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sat Mar 24 16:53:35 2018 +0100| [665edfe9f721e3c36c71e46736229e1bccd79d84] | committer: David Fuhrmann

macOS buil.sh: Workaround for breakpad symbol generation

Current tools set the library identification names to the
unversioned libraries (e.g. rpath/libvlccore.dylib), therefore
breakpad needs symbols with that library name.
Currently, breakpad does not support having the same symbols for
multiple names, therefore it cannot keep symbols for both the
versioned and unversioned variants.

Workaround that by removing the symlinks and only keeping the
unversioned name of the libraries for VLC-debug.app.

refs #19653

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=665edfe9f721e3c36c71e46736229e1bccd79d84
---

 extras/package/macosx/build.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh
index d92f9fa933..e628c03788 100755
--- a/extras/package/macosx/build.sh
+++ b/extras/package/macosx/build.sh
@@ -231,6 +231,12 @@ if [ "$PACKAGETYPE" = "u" ]; then
     rm -rf VLC-debug.app
     cp -Rp VLC.app VLC-debug.app
 
+    # Workaround for breakpad symbol parsing:
+    # Symbols must be uploaded for libvlc(core).dylib, not libvlc(core).x.dylib
+    (cd VLC-debug.app/Contents/MacOS/lib/ && rm libvlccore.dylib && mv libvlccore.*.dylib libvlccore.dylib)
+    (cd VLC-debug.app/Contents/MacOS/lib/ && rm libvlc.dylib && mv libvlc.*.dylib libvlc.dylib)
+
+
     find VLC.app/ -name "*.dylib" -exec strip -x {} \;
     find VLC.app/ -type f -name "VLC" -exec strip -x {} \;
     find VLC.app/ -type f -name "Sparkle" -exec strip -x {} \;